Skip to content

Add node pfail and fail count to cluster info metrics #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2025
Merged

Add node pfail and fail count to cluster info metrics #1910

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d61d43a
Add cluster info metrics for node pfail and fail count
hpatro Apr 2, 2025
56ddb8f
Fix clang format
hpatro Apr 2, 2025
81f0e4e
Address feedback
hpatro Apr 3, 2025
601445c
Fix flaky tests
hpatro Apr 3, 2025
fc09ebc
Add voting node pfail/fail metric
hpatro Apr 8, 2025
bf9ddf0
Cleanup
hpatro Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/unit/cluster/info.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,21 +66,23 @@ start_cluster 3 0 {tags {external:skip cluster} overrides {cluster-node-timeout
}

start_cluster 3 0 {tags {external:skip cluster} overrides {cluster-node-timeout 1000}} {
# Kill two primaries to observe partial failure on the remaining one.
pause_process [srv 0 pid]
pause_process [srv -1 pid]

test "count - node partial failure" {
wait_for_condition 500 10 {
[CI 1 cluster_nodes_pfail] eq 1 &&
[CI 2 cluster_nodes_pfail] eq 1 &&
[CI 1 cluster_nodes_fail] eq 0 &&
[CI 2 cluster_nodes_pfail] eq 2 &&
[CI 2 cluster_nodes_fail] eq 0
} else {
puts [R 1 CLUSTER INFO]
puts [R 2 CLUSTER INFO]
fail "Node 0 never timed out"
fail "Node 0/1 never timed out"
}
}

# Enable one more primary to reach quorum about node 0 failure
resume_process [srv -1 pid]

test "count - node complete failure" {
# After reaching quorum about failure,
# node 0 should be marked as FAIL across all nodes in the cluster
Expand Down
Loading