Skip to content

Commit dc9ca1b

Browse files
authored
Test coverage for ECHO for reply schema validation (#1549)
After #1545 disabled some tests for reply schema validation, we now have another issue that ECHO is not covered. ``` WARNING! The following commands were not hit at all: echo ERROR! at least one command was not hit by the tests ``` This patch adds a test case for ECHO in the unit/other test suite. I haven't checked if there are more commands that aren't covered. Signed-off-by: Viktor Söderqvist <[email protected]>
1 parent ad592f7 commit dc9ca1b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/daily.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1220,7 +1220,7 @@ jobs:
12201220
if: |
12211221
(github.event_name == 'workflow_dispatch' ||
12221222
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
1223-
(github.event_name == 'pull_request' && github.event.pull_request.base.ref != 'unstable')) &&
1223+
(github.event_name == 'pull_request' && (contains(github.event.pull_request.labels.*.name, 'run-extra-tests') || github.event.pull_request.base.ref != 'unstable'))) &&
12241224
!contains(github.event.inputs.skipjobs, 'reply-schema')
12251225
steps:
12261226
- name: prep

tests/unit/other.tcl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ start_server {tags {"other"}} {
3030
}
3131
}
3232

33+
test {Coverage: ECHO} {
34+
assert_equal bang [r ECHO bang]
35+
}
36+
3337
test {SAVE - make sure there are all the types as values} {
3438
# Wait for a background saving in progress to terminate
3539
waitForBgsave r

0 commit comments

Comments
 (0)