Skip to content

Commit a36c990

Browse files
vitarbenjoy-binbinhpatro
authored andcommitted
Expand wait condition time for slave selection test (#2604)
## Summary - extend replication wait time in `slave-selection` test ``` *** [err]: Node #10 should eventually replicate node #5 in tests/unit/cluster/slave-selection.tcl #10 didn't became slave of #5 ``` ## Testing - `./runtest --single unit/cluster/slave-selection` - `./runtest --single unit/cluster/slave-selection --valgrind` Signed-off-by: Vitali Arbuzov <[email protected]> Signed-off-by: Binbin <[email protected]> Co-authored-by: Binbin <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]>
1 parent cab4fa5 commit a36c990

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tests/unit/cluster/slave-selection.tcl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,10 @@ test "Cluster should eventually be up again" {
105105

106106
test "Node #10 should eventually replicate node #5" {
107107
set port5 [srv -5 port]
108-
wait_for_condition 1000 50 {
108+
# Valgrind runs are significantly slower and occasionally need more time
109+
# for the cluster to propagate the new primary. Use a larger timeout to
110+
# avoid spurious failures in slow environments.
111+
wait_for_condition 2000 50 {
109112
([lindex [R 10 role] 2] == $port5) &&
110113
([lindex [R 10 role] 3] eq {connected})
111114
} else {

0 commit comments

Comments
 (0)