Skip to content

Commit 988297d

Browse files
authored
Avoid log spam about cluster node failure detection by each primary (#2010)
After node failure detection/recovery and gossip by each primary, we log about the failure detection/recovery at NOTICE level which can spam the server and the behavior is quite expensive on ec2 burstable instance types. I would prefer us rolling it back to VERBOSE level. Change was introduced in #633 Signed-off-by: Harkrishn Patro <[email protected]>
1 parent 4dae83d commit 988297d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/cluster_legacy.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2410,13 +2410,13 @@ void clusterProcessGossipSection(clusterMsg *hdr, clusterLink *link) {
24102410
if (sender) {
24112411
if (flags & (CLUSTER_NODE_FAIL | CLUSTER_NODE_PFAIL)) {
24122412
if (clusterNodeIsVotingPrimary(sender) && clusterNodeAddFailureReport(node, sender)) {
2413-
serverLog(LL_NOTICE, "Node %.40s (%s) reported node %.40s (%s) as not reachable.", sender->name,
2413+
serverLog(LL_VERBOSE, "Node %.40s (%s) reported node %.40s (%s) as not reachable.", sender->name,
24142414
sender->human_nodename, node->name, node->human_nodename);
24152415
}
24162416
markNodeAsFailingIfNeeded(node);
24172417
} else {
24182418
if (clusterNodeDelFailureReport(node, sender)) {
2419-
serverLog(LL_NOTICE, "Node %.40s (%s) reported node %.40s (%s) is back online.", sender->name,
2419+
serverLog(LL_VERBOSE, "Node %.40s (%s) reported node %.40s (%s) is back online.", sender->name,
24202420
sender->human_nodename, node->name, node->human_nodename);
24212421
}
24222422
}

0 commit comments

Comments
 (0)