Added changes to rename invalid_tls_cert_auth_failures to acl_access_denied_tls_cert and formatting changes

Signed-off-by: Omkar Mestry <[email protected]>

Author: omangesg

src/acl.c

@@ -2576,7 +2576,7 @@ static void ACLUpdateInfoMetrics(int reason) {
     } else if (reason == ACL_DENIED_CHANNEL) {
         server.acl_info.invalid_channel_accesses++;
     } else if (reason == ACL_INVALID_TLS_CERT_AUTH) {
-        server.acl_info.invalid_tls_cert_auth_failures++;
+        server.acl_info.acl_access_denied_tls_cert++;
     } else {
         serverPanic("Unknown ACL_DENIED encoding");
     }

src/networking.c

@@ -37,13 +37,13 @@
 #include "fmtargs.h"
 #include "io_threads.h"
 #include "module.h"
+#include "connection.h"
 #include <strings.h>
 #include <sys/socket.h>
 #include <sys/uio.h>
 #include <math.h>
 #include <ctype.h>
 #include <stdatomic.h>
-#include "connection.h"
 #include <stdbool.h>
 
 /* This struct is used to encapsulate filtering criteria for operations on clients

src/server.c

@@ -2946,7 +2946,7 @@ void initServer(void) {
     server.acl_info.invalid_key_accesses = 0;
     server.acl_info.user_auth_failures = 0;
     server.acl_info.invalid_channel_accesses = 0;
-    server.acl_info.invalid_tls_cert_auth_failures = 0;
+    server.acl_info.acl_access_denied_tls_cert = 0;
 
     /* Create the timer callback, this is our way to process many background
      * operations incrementally, like eviction of unaccessed expired keys, etc. */
@@ -5586,10 +5586,10 @@ sds genValkeyInfoStringACLStats(sds info) {
                         "acl_access_denied_cmd:%lld\r\n"
                         "acl_access_denied_key:%lld\r\n"
                         "acl_access_denied_channel:%lld\r\n"
-                        "invalid_tls_cert_auth_failures:%lld\r\n",
+                        "acl_access_denied_tls_cert:%lld\r\n",
                         server.acl_info.user_auth_failures, server.acl_info.invalid_cmd_accesses,
                         server.acl_info.invalid_key_accesses, server.acl_info.invalid_channel_accesses,
-                        server.acl_info.invalid_tls_cert_auth_failures);
+                        server.acl_info.acl_access_denied_tls_cert);
     return info;
 }
 

src/server.h

@@ -1319,7 +1319,7 @@ typedef struct aclInfo {
     long long invalid_cmd_accesses;           /* Invalid command accesses that user doesn't have permission to */
     long long invalid_key_accesses;           /* Invalid key accesses that user doesn't have permission to */
     long long invalid_channel_accesses;       /* Invalid channel accesses that user doesn't have permission to */
-    long long invalid_tls_cert_auth_failures; /* Invalid channel accesses that user doesn't have permission to */
+    long long acl_access_denied_tls_cert; /* Invalid channel accesses that user doesn't have permission to */
 } aclInfo;
 
 struct saveparam {