Skip to content

Commit 2a53e11

Browse files
committed
fix: update test cases
Signed-off-by: arthur.lee <[email protected]>
1 parent cf973eb commit 2a53e11

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/aof.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1476,19 +1476,15 @@ int loadSingleAppendOnlyFile(char *filename) {
14761476
memcpy(server.replid, rsi.repl_id, sizeof(server.replid));
14771477
server.primary_repl_offset = rsi.repl_offset;
14781478
if (!server.primary && !server.cached_primary) {
1479-
/* we will only cache primary if replica did not synced to its primary node yet */
1479+
/* only cache myself primary if replica did not synced to its primary node yet */
14801480
replicationCachePrimaryUsingMyself();
14811481
selectDb(server.cached_primary, rsi.repl_stream_db);
14821482
}
14831483
serverLog(LL_NOTICE, "Loading preamble rdb changed replication info, replid: %s, primary_repl_offset: %lld",
14841484
server.replid, server.primary_repl_offset);
14851485
} else {
1486-
/* If this is a primary, we can save the replication info
1487-
* as secondary ID and offset, in order to allow replicas
1488-
* to partial resynchronizations with primaries. */
14891486
memcpy(server.replid2, rsi.repl_id, sizeof(server.replid));
14901487
server.second_replid_offset = rsi.repl_offset + 1;
1491-
/* Rebase primary_repl_offset from rsi.repl_offset. */
14921488
server.primary_repl_offset += rsi.repl_offset;
14931489
serverAssert(server.repl_backlog);
14941490
server.repl_backlog->offset = server.primary_repl_offset - server.repl_backlog->histlen + 1;

tests/integration/replication-4.tcl

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,9 +308,12 @@ start_server {tags {"repl"} overrides {appendonly yes}} {
308308
for {set k 0} {$k < 100} {incr k} {
309309
$master set foo_$k bar_$k
310310
}
311+
$master config rewrite
312+
$replica config rewrite
311313
wait_for_sync $replica
312314
# save replid for both master and slave
313315
set old_replid [status $master master_replid]
316+
set old_repl_offset [status $master master_repl_offset]
314317
waitForBgrewriteaof $master
315318
waitForBgrewriteaof $replica
316319

@@ -320,7 +323,9 @@ start_server {tags {"repl"} overrides {appendonly yes}} {
320323

321324
restart_server $replica_id true false
322325
set replica [srv $replica_id client]
323-
assert_equal [status $replica master_replid2] $old_replid
326+
327+
assert_equal [status $replica master_replid] $old_replid
328+
assert_equal [status $replica master_repl_offset] $old_repl_offset
324329
}
325330

326331
test {master save replid info into rdb and load it after restart} {
@@ -329,7 +334,10 @@ start_server {tags {"repl"} overrides {appendonly yes}} {
329334

330335
restart_server $master_id true false
331336
set master [srv $master_id client]
337+
set old_repl_offset [expr {$old_repl_offset+1}]
338+
332339
assert_equal [status $master master_replid2] $old_replid
340+
assert_equal [status $master second_repl_offset] $old_repl_offset
333341
}
334342
}
335343
}

0 commit comments

Comments
 (0)