Simplify API by only using non-const connect callbacks #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
reviewed
Dec 18, 2024
Signed-off-by: Björn Svensson <[email protected]>
Collaborator
|
There's a typo in |
Collaborator
Author
|
Well spotted, seems like the spellchecker in CI work quite fine as well. |
Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Dec 19, 2024
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Ping @michael-grunder
michael-grunder
approved these changes
Dec 20, 2024
Collaborator
michael-grunder
left a comment
michael-grunder
left a comment
There was a problem hiding this comment.
LGTM. The original weirdness was a bit of a hack.
bjosv
added a commit
to bjosv/libvalkey
that referenced
this pull request
Apr 28, 2025
Some examples were missed when changing the connect callback signature in PR valkey-io#142 to using a non-const context. Add -Werror to the examples Makefile to find issues in CI. Can be disabled by USE_WERROR=0 as when building libvalkey. Signed-off-by: Björn Svensson <[email protected]>
bjosv
added a commit
that referenced
this pull request
Apr 29, 2025
Some examples were missed when changing the connect callback signature in PR #142 to using a non-const context. Add -Werror to the examples Makefile to find issues in CI. Can be disabled by USE_WERROR=0 as when building libvalkey. Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
valkeyAsyncSetConnectCallbackNCsince it was first added in hiredis for backwards-compatibility reasons,and let
valkeyAsyncSetConnectCallbackuse the non-const connect callback prototype.Includes the removal of the cluster version
valkeyClusterAsyncSetConnectCallbackNCand updates of tests.