Skip to content

Commit 4e85ae9

Browse files
authored
fix: allow null and undefined in selected-item-changed event (#2281)
1 parent 753eb65 commit 4e85ae9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/vaadin-combo-box/src/interfaces.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export type ComboBoxFilterChangedEvent = CustomEvent<{ value: string }>;
5454
/**
5555
* Fired when the `selectedItem` property changes.
5656
*/
57-
export type ComboBoxSelectedItemChangedEvent<TItem> = CustomEvent<{ value: TItem }>;
57+
export type ComboBoxSelectedItemChangedEvent<TItem> = CustomEvent<{ value: TItem | null | undefined }>;
5858

5959
export interface ComboBoxEventMap<TItem> extends HTMLElementEventMap {
6060
'custom-value-set': ComboBoxCustomValueSetEvent;

packages/vaadin-combo-box/test/typings/combo-box.types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ narrowedComboBox.addEventListener('filter-changed', (event) => {
5757

5858
narrowedComboBox.addEventListener('selected-item-changed', (event) => {
5959
assertType<ComboBoxSelectedItemChangedEvent<TestComboBoxItem>>(event);
60-
assertType<TestComboBoxItem>(event.detail.value);
60+
assertType<TestComboBoxItem | null | undefined>(event.detail.value);
6161
});
6262

6363
/* ComboBoxLightElement */
@@ -96,5 +96,5 @@ narrowedComboBoxLightElement.addEventListener('filter-changed', (event) => {
9696

9797
narrowedComboBoxLightElement.addEventListener('selected-item-changed', (event) => {
9898
assertType<ComboBoxSelectedItemChangedEvent<TestComboBoxItem>>(event);
99-
assertType<TestComboBoxItem>(event.detail.value);
99+
assertType<TestComboBoxItem | null | undefined>(event.detail.value);
100100
});

0 commit comments

Comments
 (0)