Skip to content

Commit 957767d

Browse files
backespthier
authored andcommitted
Avoid deprecated TypedArray::kMaxLength field (#170)
Use TypedArray::kMaxByteLength instead.
1 parent 62e9e9a commit 957767d

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

src/node_buffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace node {
2929

3030
namespace Buffer {
3131

32-
static const size_t kMaxLength = v8::Uint8Array::kMaxLength;
32+
static const size_t kMaxLength = v8::TypedArray::kMaxByteLength;
3333

3434
typedef void (*FreeCallback)(char* data, void* hint);
3535

src/node_errors.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -272,10 +272,9 @@ inline void THROW_ERR_REQUIRE_ASYNC_MODULE(
272272

273273
inline v8::Local<v8::Object> ERR_BUFFER_TOO_LARGE(v8::Isolate* isolate) {
274274
char message[128];
275-
snprintf(message,
276-
sizeof(message),
277-
"Cannot create a Buffer larger than 0x%zx bytes",
278-
Buffer::kMaxLength);
275+
snprintf(message, sizeof(message),
276+
"Cannot create a Buffer larger than 0x%zx bytes",
277+
v8::TypedArray::kMaxByteLength);
279278
return ERR_BUFFER_TOO_LARGE(isolate, message);
280279
}
281280

0 commit comments

Comments
 (0)