Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

Description

Some tests introduced in sklearn1.8 require versions of array API packages that are not available for older python versions.

Along with bumping the python versions used for the CI jobs that test against the main branch from sklearn, it's also required to skip these problematic tests once sklearn1.8 is released.

This PR tries to deselect the tests based on python versions, but I'm not sure that it will work as intended. Currently, it seems that all of the deselections work only on versions of scikit-learn, and I'm not sure what would be the logic for deselecting based on python versions or versions of other packages instead.

Note that the actual requirement is array-api-strict>=2.4.1, which in turn requires python>=3.12.


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • All CI jobs are green or I have provided justification why they aren't.

@david-cortes-intel
Copy link
Contributor Author

/azp run Nightly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 80.49% <ø> (ø)
github 82.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-cortes-intel
Copy link
Contributor Author

/azp run Nightly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@david-cortes-intel
Copy link
Contributor Author

This kind of syntax didn't work - tests were not skipped.

@ethanglaser Any ideas about how these conditional skips could be added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant