Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

Description

SVM estimators involve calls to an internal method _fit_calibrator from sklearn, which starting with version 1.8, will require passing an array namespace as a required argument. This PR makes adjustments as necessary.

Note that this will generate merge conflicts with #2209 - not sure if it'd be easier to merge this PR or to use that other one.


Checklist:

Completeness and readability

  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

@david-cortes-intel
Copy link
Contributor Author

/azp run Nightly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sklearnex/svm/_common.py 16.66% 3 Missing and 2 partials ⚠️
Flag Coverage Δ
azure 80.43% <16.66%> (-0.06%) ⬇️
github 82.02% <16.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sklearnex/svm/_common.py 74.29% <16.66%> (-1.78%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-cortes-intel david-cortes-intel merged commit ebda062 into uxlfoundation:main Nov 28, 2025
27 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sklearn-patch sklearn patching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants