Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

Description

Adjustments for an unmerged PR scheduled for sklearn1.8 which deprecates the probability argument to SVMs.

Not sure how much it'd conflict with this other active PR: #2209


Checklist:

Completeness and readability

  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • All CI jobs are green or I have provided justification why they aren't.

@david-cortes-intel david-cortes-intel added the sklearn-patch sklearn patching label Nov 26, 2025
@david-cortes-intel david-cortes-intel changed the title MAINT: Apply sklearn1.8 deprecation of probability in SVM classifiers [Do NOT merge yet] MAINT: Apply sklearn1.8 deprecation of probability in SVM classifiers Nov 26, 2025
@david-cortes-intel
Copy link
Contributor Author

/azp run Nightly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@david-cortes-intel
Copy link
Contributor Author

/azp run Nightly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sklearnex/svm/nusvc.py 57.14% 2 Missing and 1 partial ⚠️
sklearnex/svm/svc.py 57.14% 2 Missing and 1 partial ⚠️
Flag Coverage Δ
azure 80.43% <57.14%> (-0.06%) ⬇️
github 82.04% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sklearnex/svm/nusvc.py 94.89% <57.14%> (-2.96%) ⬇️
sklearnex/svm/svc.py 83.03% <57.14%> (-2.02%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-cortes-intel
Copy link
Contributor Author

The PR in question was removed from the 1.8 milestone and switched to 1.9, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sklearn-patch sklearn patching

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant