Initial dpctl tensor removal #2779
Conversation
|
/intelci: run |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ethanglaser
requested review from
Vika-F,
ahuber21,
david-cortes-intel,
icfaust,
napetrov,
syakov-intel and
yuejiaointel
as code owners
| # ============================================================================== | ||
|
|
||
| # sklearnex IncrementalPCA example for GPU offloading with DPCtl usm ndarray: | ||
| # sklearnex IncrementalPCA example for GPU offloading with DPNP ndarray: |
There was a problem hiding this comment.
Does it make sense to have examples that offload to GPU through DPNP arrays if there's already support for array API that can avoid transferring data back and forth with a one-liner change?
|
/intelci: run |
|
/intelci: run |
| # We create GPU SyclQueue and then put data to dpnp arrays using | ||
| # the queue. It allows us to do computation on GPU. | ||
|
|
||
| queue = dpctl.SyclQueue("gpu") |
There was a problem hiding this comment.
Is it Ok to still have dpctl.SyclQueue after dpctl tensor removal?
There was a problem hiding this comment.
Yes, that's not going to be removed.
But since this is using a queue object, maybe it'd be better to offload to that instead of creating dpnp arrays on GPU that will then be moved to CPU and back again to GPU during the call.
3 participants
Description
Replacement for #2764 but without modifications to internal dpctl tensor handling. Removes to-be-deprecated dpctl tensor usage in examples and tests, replacing with dpnp array use where appropriate.
Checklist:
Completeness and readability
Testing