-
-
Notifications
You must be signed in to change notification settings - Fork 941
feat!: Port to TypeScript, closes #762 #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@LinusU @pmccarren I would particularly appreciate a review of the TS types I've added, particularly with regard to API surface where I've used overload signatures to capture the different method incantations. @ctavan et al: Thoughts on release process? I know we just pushed v10, so pushing a v11 this soon after feels a bit... sudden? We could do a prerelease ("11.0.0-beta") and dist tag as |
|
@joshkel As the most recent contributor to @types/uuid, I'd certainly appreciate any feedback you have on this. |
|
Final call. Merging this by week's end unless someone objects. |
…s, pull uuidjs#763 preventing native.randomUUID being used
Update dependencies still compatible with Node 18 and CommonJS, without any code changes required. Major version upgrades: - [bcryptjs v3](https://github.com/dcodeIO/bcrypt.js/releases/tag/v3.0.0) - [commander v13](https://github.com/tj/commander.js/releases/tag/v13.0.0) - [mime-types v3](https://github.com/jshttp/mime-types/releases/tag/v3.0.0) - [package-json v9](https://github.com/sindresorhus/package-json/releases/tag/v9.0.0) - [uuid v11](https://github.com/uuidjs/uuid/releases/tag/v11.0.0) Included type definitions: - bcryptjs>=3.0.0 (dcodeIO/bcrypt.js@2f45985) - uuid>=11.0.0 (uuidjs/uuid#763) - sqlite3>=5.1.0 (TryGhost/node-sqlite3#1527)
Switching the codebase to Typescript.
Uint8Arrayfor binary uuids throughout (BREAKING CHANGE)jesttonode:testtscfor generating buidlsOther notes:
Uint8Arrayfor binary UUIDsexamples/node-jesttest passes, but I don't see it being run as part of CI ornpm testanywhere. I'm tempted to remove it. 🤔eslint@latest, and switched config to ESM.@wdio/*@latestprettierconfig to ESMtasks.jsonstarts thebuild:watchandtest:watchscripts automatically when you open the projectextensions.jsonidentifies the plugins that devs should use to apply oureslintandprettiersettings while editing codepackage.json#scriptsalphabeticallybuild:watchandtest:watchscripts, which I'm using in vscodedist/esmdirectory (unless they're explicitely testing other dist/* builds.build.shnow builds ESM and CJS versions of code usingtscrather than babel.dist/*.jsfiles can now be found indist/esm, alongside the other builds (esm-browser,cjs, andcjs-browser)Uint8Arrayfor binary (byte) UUID data structures throughout. The one exception is the return type formd5andsha1on node, which is still Buffer (but that's a subclass of Uint8Array these days anyways so... 🤷)