Skip to content

Conversation

@RoussKS
Copy link
Contributor

@RoussKS RoussKS commented Dec 20, 2024

Refactor to handle request validation the Laravel way
Allows for separation of concerns for request & form validations, away from services
Add Update request validation

  • Add new custom rule for provider config validation and a Factory for instantiation
  • Add request class validation for separation of concerns, use factory in request method for form validation
  • Rename existing store form request class (validation) to match directory structure
  • Refactor Store Provision configuration controller to use new logic
  • Refactor Update Provision configuration controller to use new logic
  • Remove redundant provision configuration service validation as no longer required
  • Remove redundant provision configuration service delete method as not used in the app
  • Remove redundant Error Handler methods

@RoussKS RoussKS requested a review from uphlewis December 20, 2024 15:00
@RoussKS RoussKS self-assigned this Dec 20, 2024
@RoussKS RoussKS changed the title Small refactor to handle request validation the Laravel way Refactor Store & Update provision config requests validation to use the Laravel way Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants