Fix patterns of provide_context gets panicked #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes two cases where provide_context panics even though the previous call of `is_boundary` returns a PreContext error. The primary cause is `provide_context` assumes its state as Regional or Emoji; otherwise it gets panicked with 'invalid state!' However: - if the chunk starts with the cursor position, it requires pre-context for `cat_before` (and that's necessary for some cases indeed). so provide_context should fill `cat_before` in such case. - if both `cat_before` and `cat_after` are RIS and the boundary is undecided by the chunk, it requires pre-context but it does not set its state to Regional. This is done by setting state within `handle_regional`.
raphlinus
approved these changes
Mar 19, 2018
Contributor
raphlinus
left a comment
raphlinus
left a comment
There was a problem hiding this comment.
These changes look good to me. Thanks to jmuk for testing more thoroughly, clearly that's something I should have done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two cases where provide_context panics even though the previous call of
is_boundaryreturns a PreContext error.The primary cause is
provide_contextassumes its state as Regional or Emoji; otherwise it gets panicked with 'invalid state!'However:
cat_beforeregardless of its state (and that's necessary for some cases indeed). so provide_context should fillcat_beforein such case.cat_beforeandcat_afterare RIS and the boundary is undecided by the chunk, it requires pre-context but it does not set its state to Regional. This is done by setting state withinhandle_regional.