Inflection-72 Improve multi-language handling #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grhoten
commented
Jan 27, 2025
| static final String IGNORE_UNANNOTATED_SURFACE_FORM = "--ignore-unannotated-entries"; | ||
| static final String ADD_NORMALIZED_ENTRY = "--add-normalized-entry"; | ||
| static final String LOCALE_OPT = "--locale"; | ||
| static final String LANGUAGE_OPT = "--language"; |
Member
Author
There was a problem hiding this comment.
Please note that I changed this option. It's now a comma separated list.
grhoten
commented
Jan 27, 2025
| .configure(JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES, true) | ||
| .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | ||
| var lexParser = new ParseWikidata(parserOptions); | ||
| LexemesJsonDeserializer.setLanguage(parserOptions.locales); |
Member
Author
There was a problem hiding this comment.
I couldn't figure out how to register a module in Jackson with parameters. So I did it this way with a static variable.
nciric
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #72
Some of the inflection variants aren't handled well. Some changes are needed to improve handling them. Here are some examples.