Skip to content

Commit c2f2751

Browse files
authored
Merge pull request #16 from unicitynetwork/partition-params
Add partition-params
2 parents 7d90e1b + f6ef2ad commit c2f2751

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

cli/ubft/cmd/shard_conf_generate.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ type (
2424
EpochStart uint64
2525
T2Timeout uint32
2626
NodeInfoFiles []string
27+
PartitionParams map[string]string
2728
}
2829
)
2930

@@ -48,6 +49,7 @@ func shardConfGenerateCmd(baseFlags *baseFlags) *cobra.Command {
4849
panic(err)
4950
}
5051
cmd.Flags().StringSliceVarP(&flags.NodeInfoFiles, "node-info", "n", []string{}, "path to node info files")
52+
cmd.Flags().StringToStringVar(&flags.PartitionParams, "partition-params", nil, "partition parameters as key=value pairs")
5153

5254
return cmd
5355
}
@@ -85,6 +87,7 @@ func shardConfGenerate(flags *ShardConfGenerateFlags) error {
8587
UnitIDLen: 256,
8688
T2Timeout: time.Duration(flags.T2Timeout) * time.Millisecond,
8789
Validators: nodes,
90+
PartitionParams: flags.PartitionParams,
8891
}
8992

9093
if err = shardConf.IsValid(); err != nil {

cli/ubft/cmd/shard_conf_generate_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ import (
66
"testing"
77

88
"github.com/stretchr/testify/require"
9-
testobserve "github.com/unicitynetwork/bft-core/internal/testutils/observability"
109
"github.com/unicitynetwork/bft-go-base/types"
1110
"github.com/unicitynetwork/bft-go-base/util"
11+
12+
testobserve "github.com/unicitynetwork/bft-core/internal/testutils/observability"
1213
)
1314

1415
func TestShardConf_Generate(t *testing.T) {
@@ -33,6 +34,7 @@ func TestShardConf_Generate(t *testing.T) {
3334
"--partition-type-id", "1",
3435
"--epoch", "8",
3536
"--epoch-start", "100",
37+
"--partition-params", "dFG=6",
3638
})
3739
require.NoError(t, cmd.Execute(context.Background()))
3840

@@ -45,4 +47,6 @@ func TestShardConf_Generate(t *testing.T) {
4547
require.Equal(t, uint64(8), rec.Epoch)
4648
require.Equal(t, uint64(100), rec.EpochStart)
4749
require.Len(t, rec.Validators, 1)
50+
require.Len(t, rec.PartitionParams, 1)
51+
require.Equal(t, "6", rec.PartitionParams["dFG"])
4852
}

0 commit comments

Comments
 (0)