Skip to content

Commit 098d7dc

Browse files
authored
fix: dataset pagination (#1699)
1 parent 774c0e9 commit 098d7dc

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

src/unfold/views.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,28 @@ class DatasetChangeList(ChangeList):
2626
is_dataset = True
2727

2828
def __init__(self, request: HttpRequest, *args: Any, **kwargs: Any) -> None:
29-
search_var = f"{kwargs.get('model')._meta.model_name}-q"
30-
page_var = f"{kwargs.get('model')._meta.model_name}-p"
29+
self.search_var = f"{kwargs.get('model')._meta.model_name}-q"
30+
self.page_var = f"{kwargs.get('model')._meta.model_name}-p"
3131

32-
_search_form = DatasetChangeListSearchForm(request.GET, search_var=search_var)
32+
_search_form = DatasetChangeListSearchForm(
33+
request.GET, search_var=self.search_var
34+
)
3335
if not _search_form.is_valid():
3436
for error in _search_form.errors.values():
3537
messages.error(request, ", ".join(error))
3638

37-
self.dataset_search_query = _search_form.cleaned_data.get(search_var) or ""
39+
self.dataset_search_query = _search_form.cleaned_data.get(self.search_var) or ""
3840

3941
super().__init__(request, *args, **kwargs)
4042

43+
def get_results(self, request: HttpRequest) -> None:
4144
try:
42-
self.page_num = int(request.GET.get(page_var, 1))
45+
self.page_num = int(request.GET.get(self.page_var, 1))
4346
except ValueError:
4447
self.page_num = 1
4548

49+
super().get_results(request)
50+
4651
def get_queryset(self, request, exclude_parameters=None):
4752
self.query = self.dataset_search_query
4853
return super().get_queryset(request, exclude_parameters)

0 commit comments

Comments
 (0)