From ac0f96fa752cbc7e69bb29d5c6f592473de37c1e Mon Sep 17 00:00:00 2001
From: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Date: Tue, 19 Sep 2023 22:32:38 +0200
Subject: [PATCH 1/3] Only allow creating folder at root or under another
 folder

---
 .../src/views/mediaTypes/create.controller.js            | 5 +++--
 .../src/views/mediaTypes/create.html                     | 9 ++++-----
 .../src/views/memberTypes/create.controller.js           | 5 +++--
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.controller.js b/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.controller.js
index 435ece4bb9cd..df2647372055 100644
--- a/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.controller.js
@@ -9,8 +9,9 @@
 function MediaTypesCreateController($scope, $location, navigationService, mediaTypeResource, formHelper, appState, localizationService) {
 
     $scope.model = {
-        folderName: "",
-        creatingFolder: false
+      allowCreateFolder: $scope.currentNode.parentId === null || $scope.currentNode.nodeType === 'container',
+      folderName: "",
+      creatingFolder: false
     };
 
     var node = $scope.currentNode;
diff --git a/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html b/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html
index bd6ef087f4a5..f7e68be2d788 100644
--- a/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html
+++ b/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html
@@ -10,9 +10,8 @@ <h5>
         </h5>
 
         <ul class="umb-actions umb-actions-child">
-          <li class="umb-action">
-            <button class="umb-action-link umb-outline btn-reset" ng-click="createMediaType()" type="button"
-                    umb-auto-focus>
+          <li data-element="action-mediaType" class="umb-action">
+            <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="createMediaType()" umb-auto-focus>
               <umb-icon class="icon large" icon="icon-item-arrangement"></umb-icon>
               <span class="menu-label">
                                 <localize key="general_new">New</localize>
@@ -20,8 +19,8 @@ <h5>
                             </span>
             </button>
           </li>
-          <li class="umb-action">
-            <button class="umb-action-link umb-outline btn-reset" ng-click="showCreateFolder()" type="button">
+          <li data-element="action-folder" class="umb-action" ng-if="model.allowCreateFolder">
+            <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="showCreateFolder()">
               <umb-icon class="icon large" icon="icon-folder"></umb-icon>
               <span class="menu-label"><localize key="general_folder">Folder</localize>...</span>
             </button>
diff --git a/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.controller.js b/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.controller.js
index 550ad7ed35fc..4210d162d306 100644
--- a/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.controller.js
@@ -9,8 +9,9 @@
 function MemberTypesCreateController($scope, $location, navigationService, memberTypeResource, formHelper, appState, localizationService) {
 
     $scope.model = {
-        folderName: "",
-        creatingFolder: false
+      allowCreateFolder: $scope.currentNode.parentId === null || $scope.currentNode.nodeType === 'container',
+      folderName: "",
+      creatingFolder: false
     };
 
     var node = $scope.currentNode;

From a3e841d6ce5edee794290e33defd17b550ed5f66 Mon Sep 17 00:00:00 2001
From: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Date: Wed, 20 Sep 2023 13:33:55 +0200
Subject: [PATCH 2/3] Fix typos in error message

---
 .../src/common/resources/contenttype.resource.js                | 2 +-
 .../src/common/resources/mediatype.resource.js                  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/common/resources/contenttype.resource.js b/src/Umbraco.Web.UI.Client/src/common/resources/contenttype.resource.js
index dfac875e5e8c..ccc80dee3707 100644
--- a/src/Umbraco.Web.UI.Client/src/common/resources/contenttype.resource.js
+++ b/src/Umbraco.Web.UI.Client/src/common/resources/contenttype.resource.js
@@ -323,7 +323,7 @@ function contentTypeResource($q, $http, umbRequestHelper, umbDataFormatter, loca
                         "contentTypeApiBaseUrl",
                         "DeleteContainer",
                         [{ id: id }])),
-                'Failed to delete content type contaier');
+                'Failed to delete content type container');
         },
 
         /**
diff --git a/src/Umbraco.Web.UI.Client/src/common/resources/mediatype.resource.js b/src/Umbraco.Web.UI.Client/src/common/resources/mediatype.resource.js
index f7bba87ad568..a46ac9184e0d 100644
--- a/src/Umbraco.Web.UI.Client/src/common/resources/mediatype.resource.js
+++ b/src/Umbraco.Web.UI.Client/src/common/resources/mediatype.resource.js
@@ -166,7 +166,7 @@ function mediaTypeResource($q, $http, umbRequestHelper, umbDataFormatter, locali
                        "mediaTypeApiBaseUrl",
                        "DeleteContainer",
                        [{ id: id }])),
-               'Failed to delete content type contaier');
+               'Failed to delete content type container');
         },
 
         /**

From 168f9bd8691c17d0664a8b5b770089ae22624bd7 Mon Sep 17 00:00:00 2001
From: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Date: Wed, 20 Sep 2023 13:42:37 +0200
Subject: [PATCH 3/3] Add data-element to member type create dialog

---
 .../src/views/mediaTypes/create.html          | 11 ++++++----
 .../src/views/memberTypes/create.html         | 21 ++++++++++---------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html b/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html
index f7e68be2d788..36a0fce9f218 100644
--- a/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html
+++ b/src/Umbraco.Web.UI.Client/src/views/mediaTypes/create.html
@@ -14,15 +14,17 @@ <h5>
             <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="createMediaType()" umb-auto-focus>
               <umb-icon class="icon large" icon="icon-item-arrangement"></umb-icon>
               <span class="menu-label">
-                                <localize key="general_new">New</localize>
-                                <localize key="content_mediatype">Media type</localize>
-                            </span>
+                  <localize key="general_new">New</localize>
+                  <localize key="content_mediatype">Media type</localize>
+              </span>
             </button>
           </li>
           <li data-element="action-folder" class="umb-action" ng-if="model.allowCreateFolder">
             <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="showCreateFolder()">
               <umb-icon class="icon large" icon="icon-folder"></umb-icon>
-              <span class="menu-label"><localize key="general_folder">Folder</localize>...</span>
+              <span class="menu-label">
+                <localize key="general_folder">Folder</localize>
+              </span>
             </button>
           </li>
         </ul>
@@ -34,6 +36,7 @@ <h5>
         <localize key="buttons_somethingElse">Do something else</localize>
       </button>
     </div>
+
   </div>
 
   <div ng-cloak ng-show="model.creatingFolder">
diff --git a/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.html b/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.html
index 5bcf6c42bf02..ac6f633db898 100644
--- a/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.html
+++ b/src/Umbraco.Web.UI.Client/src/views/memberTypes/create.html
@@ -1,4 +1,5 @@
 <div ng-controller="Umbraco.Editors.MemberTypes.CreateController">
+
     <div class="umbracoDialog umb-dialog-body with-footer">
         <div class="umb-pane" ng-if="!model.creatingFolder">
             <h5>
@@ -6,7 +7,16 @@ <h5>
             </h5>
 
             <ul class="umb-actions umb-actions-child">
-                <li class="umb-action">
+                <li data-element="action-memberType" class="umb-action">
+                  <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="createMemberType()">
+                    <umb-icon icon="icon-item-arrangement" class="icon large"></umb-icon>
+                    <span class="menu-label">
+                      <localize key="general_new">New</localize>
+                      <localize key="content_memberType">Member type</localize>
+                    </span>
+                  </button>
+                </li>
+                <li data-element="action-folder" class="umb-action">
                     <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="showCreateFolder()">
                         <umb-icon icon="icon-folder" class="icon large"></umb-icon>
                         <span class="menu-label">
@@ -14,15 +24,6 @@ <h5>
                         </span>
                     </button>
                 </li>
-                <li class="umb-action">
-                    <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="createMemberType()">
-                        <umb-icon icon="icon-item-arrangement" class="icon large"></umb-icon>
-                        <span class="menu-label">
-                            <localize key="general_new">New</localize>&nbsp;
-                            <localize key="content_memberType">Member type</localize>
-                        </span>
-                    </button>
-                </li>
             </ul>
         </div>