Performance: Embeds the API of selected extra Conditions (#21188)

nielslyngsoe · web-flow · commit 45ae5aaac039 · 2025-12-17T21:43:08.000+01:00
embeds the API of selected Conditions
diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block/conditions/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block/conditions/manifests.ts
@@ -1,22 +1,25 @@
+import UmbBlockEntryShowContentEditCondition from './block-entry-show-content-edit.condition.js';
+import UmbBlockWorkspaceHasSettingsCondition from './block-workspace-has-settings.condition.js';
+import UmbBlockEntryIsExposedCondition from './block-workspace-is-exposed.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifests: Array<ManifestCondition> = [
 	{
 		type: 'condition',
 		name: 'Block Has Settings Condition',
 		alias: 'Umb.Condition.BlockWorkspaceHasSettings',
-		api: () => import('./block-workspace-has-settings.condition.js'),
+		api: UmbBlockWorkspaceHasSettingsCondition,
 	},
 	{
 		type: 'condition',
 		name: 'Block Show Content Edit Condition',
 		alias: 'Umb.Condition.BlockEntryShowContentEdit',
-		api: () => import('./block-entry-show-content-edit.condition.js'),
+		api: UmbBlockEntryShowContentEditCondition,
 	},
 	{
 		type: 'condition',
 		name: 'Block Workspace Is Exposed Condition',
 		alias: 'Umb.Condition.BlockWorkspaceIsExposed',
-		api: () => import('./block-workspace-is-exposed.condition.js'),
+		api: UmbBlockEntryIsExposedCondition,
 	},
 ];
diff --git a/src/Umbraco.Web.UI.Client/src/packages/content/content/collection/workspace-has-content-collection/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/content/content/collection/workspace-has-content-collection/manifests.ts
@@ -1,10 +1,11 @@
 import { UMB_WORKSPACE_HAS_CONTENT_COLLECTION_CONDITION_ALIAS } from './constants.js';
+import { UmbWorkspaceHasContentCollectionCondition } from './workspace-has-content-collection.condition.js';
 
 export const manifests: Array<UmbExtensionManifest> = [
 	{
 		type: 'condition',
 		name: 'Workspace Has Collection Condition',
 		alias: UMB_WORKSPACE_HAS_CONTENT_COLLECTION_CONDITION_ALIAS,
-		api: () => import('./workspace-has-content-collection.condition.js'),
+		api: UmbWorkspaceHasContentCollectionCondition,
 	},
 ];
diff --git a/src/Umbraco.Web.UI.Client/src/packages/content/content/conditions/has-properties/content-has-properties.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/content/content/conditions/has-properties/content-has-properties.condition.manifest.ts
@@ -1,8 +1,9 @@
+import { UmbContentHasPropertiesWorkspaceCondition } from './content-has-properties.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Content has properties Workspace Condition',
 	alias: 'Umb.Condition.Workspace.ContentHasProperties',
-	api: () => import('./content-has-properties.condition.js'),
+	api: UmbContentHasPropertiesWorkspaceCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/collection/conditions/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/core/collection/conditions/manifests.ts
@@ -1,3 +1,4 @@
+import UmbCollectionAliasCondition from './collection-alias.condition.js';
 import { UMB_COLLECTION_ALIAS_CONDITION } from './constants.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
@@ -6,6 +7,6 @@ export const manifests: Array<ManifestCondition> = [
 		type: 'condition',
 		name: 'Collection Alias Condition',
 		alias: UMB_COLLECTION_ALIAS_CONDITION,
-		api: () => import('./collection-alias.condition.js'),
+		api: UmbCollectionAliasCondition,
 	},
 ];
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/has-children/condition/entity-has-children.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/has-children/condition/entity-has-children.condition.manifest.ts
@@ -1,9 +1,10 @@
 import { UMB_ENTITY_HAS_CHILDREN_CONDITION_ALIAS } from './constants.js';
+import { UmbEntityHasChildrenCondition } from './entity-has-children.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Entity Has Children Condition',
 	alias: UMB_ENTITY_HAS_CHILDREN_CONDITION_ALIAS,
-	api: () => import('./entity-has-children.condition.js'),
+	api: UmbEntityHasChildrenCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/entity/entity-type/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/core/entity/entity-type/manifests.ts
@@ -1,10 +1,11 @@
 import { UMB_ENTITY_TYPE_CONDITION_ALIAS } from './constants.js';
+import { UmbEntityTypeCondition } from './entity-type.condition.js';
 
 export const manifests: Array<UmbExtensionManifest> = [
 	{
 		type: 'condition',
 		name: 'Umbraco Entity Type Condition',
 		alias: UMB_ENTITY_TYPE_CONDITION_ALIAS,
-		api: () => import('./entity-type.condition.js'),
+		api: UmbEntityTypeCondition,
 	},
 ];
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/entity/entity-unique/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/core/entity/entity-unique/manifests.ts
@@ -1,10 +1,11 @@
 import { UMB_ENTITY_UNIQUE_CONDITION_ALIAS } from './constants.js';
+import { UmbEntityUniqueCondition } from './entity-unique.condition.js';
 
 export const manifests: Array<UmbExtensionManifest> = [
 	{
 		type: 'condition',
 		name: 'Umbraco Entity Unique Condition',
 		alias: UMB_ENTITY_UNIQUE_CONDITION_ALIAS,
-		api: () => import('./entity-unique.condition.js'),
+		api: UmbEntityUniqueCondition,
 	},
 ];
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/conditions/is-not-trashed/entity-is-not-trashed.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/conditions/is-not-trashed/entity-is-not-trashed.condition.manifest.ts
@@ -1,9 +1,10 @@
 import { UMB_ENTITY_IS_NOT_TRASHED_CONDITION_ALIAS } from './constants.js';
+import { UmbEntityIsNotTrashedCondition } from './entity-is-not-trashed.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Entity Is not trashed Condition',
 	alias: UMB_ENTITY_IS_NOT_TRASHED_CONDITION_ALIAS,
-	api: () => import('./entity-is-not-trashed.condition.js'),
+	api: UmbEntityIsNotTrashedCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/conditions/is-trashed/entity-is-trashed.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/conditions/is-trashed/entity-is-trashed.condition.manifest.ts
@@ -1,9 +1,10 @@
 import { UMB_ENTITY_IS_TRASHED_CONDITION_ALIAS } from './constants.js';
+import { UmbEntityIsTrashedCondition } from './entity-is-trashed.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Entity Is trashed Condition',
 	alias: UMB_ENTITY_IS_TRASHED_CONDITION_ALIAS,
-	api: () => import('./entity-is-trashed.condition.js'),
+	api: UmbEntityIsTrashedCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/conditions/is-trashed/entity-is-trashed.condition.ts b/src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/conditions/is-trashed/entity-is-trashed.condition.ts
@@ -7,7 +7,10 @@ import type {
 } from '@umbraco-cms/backoffice/extension-api';
 import { UmbConditionBase } from '@umbraco-cms/backoffice/extension-registry';
 
-export class UmbIsTrashedCondition extends UmbConditionBase<UmbConditionConfigBase> implements UmbExtensionCondition {
+export class UmbEntityIsTrashedCondition
+	extends UmbConditionBase<UmbConditionConfigBase>
+	implements UmbExtensionCondition
+{
 	constructor(host: UmbControllerHost, args: UmbConditionControllerArguments<UmbConditionConfigBase>) {
 		super(host, args);
 
@@ -19,4 +22,4 @@ export class UmbIsTrashedCondition extends UmbConditionBase<UmbConditionConfigBa
 	}
 }
 
-export { UmbIsTrashedCondition as api };
+export { UmbEntityIsTrashedCondition as api };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/manifests.ts
@@ -1,3 +1,4 @@
+import { UmbAllowDocumentRecycleBinCurrentUserCondition } from './allow-document-recycle-bin.condition.js';
 import { manifests as entityActionManifests } from './entity-action/manifests.js';
 import { manifests as menuManifests } from './menu/manifests.js';
 import { manifests as repositoryManifests } from './repository/manifests.js';
@@ -9,7 +10,7 @@ export const manifests: Array<UmbExtensionManifest> = [
 		type: 'condition',
 		name: 'Allow Document Recycle Bin Current User Condition',
 		alias: 'Umb.Condition.CurrentUser.AllowDocumentRecycleBin',
-		api: () => import('./allow-document-recycle-bin.condition.js'),
+		api: UmbAllowDocumentRecycleBinCurrentUserCondition,
 	},
 	...entityActionManifests,
 	...menuManifests,
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/user-permissions/document/conditions/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/user-permissions/document/conditions/manifests.ts
@@ -1,10 +1,11 @@
 import { UMB_DOCUMENT_USER_PERMISSION_CONDITION_ALIAS } from './constants.js';
+import { UmbDocumentUserPermissionCondition } from './document-user-permission.condition.js';
 
 export const manifests: Array<UmbExtensionManifest> = [
 	{
 		type: 'condition',
 		name: 'Document User Permission Condition',
 		alias: UMB_DOCUMENT_USER_PERMISSION_CONDITION_ALIAS,
-		api: () => import('./document-user-permission.condition.js'),
+		api: UmbDocumentUserPermissionCondition,
 	},
 ];
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/conditions/is-not-trashed/document-is-not-trashed.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/conditions/is-not-trashed/document-is-not-trashed.condition.manifest.ts
@@ -1,9 +1,10 @@
 import { UMB_DOCUMENT_IS_NOT_TRASHED_CONDITION_ALIAS } from './constants.js';
+import { UmbDocumentIsNotTrashedWorkspaceCondition } from './document-is-not-trashed.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Document is not trashed Workspace Condition',
 	alias: UMB_DOCUMENT_IS_NOT_TRASHED_CONDITION_ALIAS,
-	api: () => import('./document-is-not-trashed.condition.js'),
+	api: UmbDocumentIsNotTrashedWorkspaceCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/conditions/is-trashed/document-is-trashed.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/conditions/is-trashed/document-is-trashed.condition.manifest.ts
@@ -1,9 +1,10 @@
 import { UMB_DOCUMENT_IS_TRASHED_CONDITION_ALIAS } from './constants.js';
+import { UmbDocumentIsTrashedWorkspaceCondition } from './document-is-trashed.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Document is trashed Workspace Condition',
 	alias: UMB_DOCUMENT_IS_TRASHED_CONDITION_ALIAS,
-	api: () => import('./document-is-trashed.condition.js'),
+	api: UmbDocumentIsTrashedWorkspaceCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/conditions/language-user-permission/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/language/conditions/language-user-permission/manifests.ts
@@ -1,8 +1,9 @@
 import { UMB_LANGUAGE_USER_PERMISSION_CONDITION_ALIAS } from './constants.js';
+import { UmbLanguageUserPermissionCondition } from './language-user-permission.condition.js';
 
 export const manifest: UmbExtensionManifest = {
 	type: 'condition',
 	name: 'Language User Permission Condition',
 	alias: UMB_LANGUAGE_USER_PERMISSION_CONDITION_ALIAS,
-	api: () => import('./language-user-permission.condition.js'),
+	api: UmbLanguageUserPermissionCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/user/current-user/conditions/group-id/group-id.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/user/current-user/conditions/group-id/group-id.condition.manifest.ts
@@ -1,9 +1,10 @@
 import { UMB_CURRENT_USER_GROUP_ID_CONDITION_ALIAS } from './constants.js';
+import { UmbCurrentUserGroupCondition } from './group-id.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Current user group id Condition',
 	alias: UMB_CURRENT_USER_GROUP_ID_CONDITION_ALIAS,
-	api: () => import('./group-id.condition.js'),
+	api: UmbCurrentUserGroupCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/user/current-user/conditions/is-admin/is-admin.condition.manifest.ts b/src/Umbraco.Web.UI.Client/src/packages/user/current-user/conditions/is-admin/is-admin.condition.manifest.ts
@@ -1,9 +1,10 @@
 import { UMB_CURRENT_USER_IS_ADMIN_CONDITION_ALIAS } from './constants.js';
+import { UmbCurrentUserIsAdminCondition } from './is-admin.condition.js';
 import type { ManifestCondition } from '@umbraco-cms/backoffice/extension-api';
 
 export const manifest: ManifestCondition = {
 	type: 'condition',
 	name: 'Current user is admin Condition',
 	alias: UMB_CURRENT_USER_IS_ADMIN_CONDITION_ALIAS,
-	api: () => import('./is-admin.condition.js'),
+	api: UmbCurrentUserIsAdminCondition,
 };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/user/current-user/conditions/is-admin/is-admin.condition.ts b/src/Umbraco.Web.UI.Client/src/packages/user/current-user/conditions/is-admin/is-admin.condition.ts
@@ -7,7 +7,7 @@ import type {
 } from '@umbraco-cms/backoffice/extension-api';
 import { UmbConditionBase } from '@umbraco-cms/backoffice/extension-registry';
 
-export class UmbContentHasPropertiesWorkspaceCondition
+export class UmbCurrentUserIsAdminCondition
 	extends UmbConditionBase<UmbConditionConfigBase>
 	implements UmbExtensionCondition
 {
@@ -17,4 +17,4 @@ export class UmbContentHasPropertiesWorkspaceCondition
 	}
 }
 
-export { UmbContentHasPropertiesWorkspaceCondition as api };
+export { UmbCurrentUserIsAdminCondition as api };
diff --git a/src/Umbraco.Web.UI.Client/src/packages/user/user-permission/fallback-permission-condition/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/user/user-permission/fallback-permission-condition/manifests.ts
@@ -1,10 +1,11 @@
 import { UMB_FALLBACK_USER_PERMISSION_CONDITION_ALIAS } from './constants.js';
+import { UmbFallbackUserPermissionCondition } from './fallback-user-permission.condition.js';
 
 export const manifests: Array<UmbExtensionManifest> = [
 	{
 		type: 'condition',
 		name: 'User Fallback Permission Condition',
 		alias: UMB_FALLBACK_USER_PERMISSION_CONDITION_ALIAS,
-		api: () => import('./fallback-user-permission.condition.js'),
+		api: UmbFallbackUserPermissionCondition,
 	},
 ];

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,10 @@ import type {`
`7`	`7`	`} from '@umbraco-cms/backoffice/extension-api';`
`8`	`8`	`import { UmbConditionBase } from '@umbraco-cms/backoffice/extension-registry';`
`9`	`9`
`10`		`-export class UmbIsTrashedCondition extends UmbConditionBase<UmbConditionConfigBase> implements UmbExtensionCondition {`
	`10`	`+export class UmbEntityIsTrashedCondition`
	`11`	`+ extends UmbConditionBase<UmbConditionConfigBase>`
	`12`	`+ implements UmbExtensionCondition`
	`13`	`+{`
`11`	`14`	`constructor(host: UmbControllerHost, args: UmbConditionControllerArguments<UmbConditionConfigBase>) {`
`12`	`15`	`super(host, args);`
`13`	`16`
`@@ -19,4 +22,4 @@ export class UmbIsTrashedCondition extends UmbConditionBase<UmbConditionConfigBa`
`19`	`22`	`}`
`20`	`23`	`}`
`21`	`24`
`22`		`-export { UmbIsTrashedCondition as api };`
	`25`	`+export { UmbEntityIsTrashedCondition as api };`