fix(sitemap generation) update old sitemap path

Author: umaarov

app/Console/Commands/GenerateSitemap.php

@@ -7,7 +7,6 @@
 use Carbon\Carbon;
 use Exception;
 use Illuminate\Console\Command;
-use Illuminate\Support\Str;
 use Spatie\Sitemap\Sitemap;
 use Spatie\Sitemap\Tags\Url;
 
@@ -53,26 +52,33 @@ public function handle()
 
         // 2. Add Posts
         $this->info('Adding posts...');
-        Post::query()
+
+        Post::with('user')
             // ->where('is_published', true)
             // ->where('moderation_status', 'approved')
             // ->whereNotNull('slug')
             ->orderBy('created_at', 'desc')
             ->chunk(200, function ($posts) use ($sitemap) {
                 foreach ($posts as $post) {
-                    $slug = Str::slug($post->question);
                     try {
-                        $url = route('posts.show.user-scoped', ['username' => $post->user->username, 'post' => $post->id]);
-                        $sitemap->add(Url::create($url)
-                            ->setLastModificationDate($post->updated_at)
-                            ->setChangeFrequency(Url::CHANGE_FREQUENCY_WEEKLY)
-                            ->setPriority(0.9));
-                        // $post->update(['slug' => $slug]);
+                        $url = route('posts.show.user-scoped', [
+                            'username' => $post->user->username,
+                            'post' => $post->id,
+                        ]);
+
+                        $sitemap->add(
+                            Url::create($url)
+                                ->setLastModificationDate($post->updated_at)
+                                ->setChangeFrequency(Url::CHANGE_FREQUENCY_WEEKLY)
+                                ->setPriority(0.9)
+                        );
+
                     } catch (Exception $e) {
                         $this->error("Could not generate URL for Post ID {$post->id} ('{$post->question}'): " . $e->getMessage());
                     }
                 }
             });
+
         $this->info('Posts added.');
 
         // 3. Add User Profiles

app/Http/Controllers/SitemapController.php

@@ -15,7 +15,7 @@ public function index(): StreamedResponse
             echo View::make('sitemap.partials.header')->render();
             echo View::make('sitemap.partials.static')->render();
 
-            Post::chunkById(2000, function ($posts) {
+            Post::with('user')->chunkById(2000, function ($posts) {
                 echo View::make('sitemap.partials.posts', ['posts' => $posts])->render();
             });
 

resources/views/sitemap/partials/posts.blade.php

@@ -1,21 +1,23 @@
 @foreach ($posts as $post)
     <url>
-        <loc>{{ url('p/' . $post->id . '/' . Illuminate\Support\Str::slug($post->question)) }}</loc>
+        <loc>{{ route('posts.show.user-scoped', ['username' => $post->user->username, 'post' => $post->id]) }}</loc>
         <lastmod>{{ $post->updated_at->tz('Asia/Tashkent')->toAtomString() }}</lastmod>
         <changefreq>weekly</changefreq>
         <priority>0.9</priority>
+
         @if ($post->option_one_image)
             <image:image>
                 <image:loc>{{ asset('storage/' . $post->option_one_image) }}</image:loc>
-                <image:title>{{ htmlspecialchars($post->option_one_title) }}</image:title>
-                <image:caption>{{ htmlspecialchars($post->question) }}</image:caption>
+                <image:title>{{ $post->option_one_title }}</image:title>
+                <image:caption>{{ $post->question }}</image:caption>
             </image:image>
         @endif
+
         @if ($post->option_two_image)
             <image:image>
                 <image:loc>{{ asset('storage/' . $post->option_two_image) }}</image:loc>
-                <image:title>{{ htmlspecialchars($post->option_two_title) }}</image:title>
-                <image:caption>{{ htmlspecialchars($post->question) }}</image:caption>
+                <image:title>{{ $post->option_two_title }}</image:title>
+                <image:caption>{{ $post->question }}</image:caption>
             </image:image>
         @endif
     </url>