Skip to content

Commit 1557a97

Browse files
alanjhewittcameronbateman-mo
alanjhewitt
and
cameronbateman-mo
authored
Bug in AOD diagnostics (MetOffice#94)
Co-authored-by: Cameron Bateman <cameron.bateman@metoffice.gov.uk>
1 parent 0fb9b1a commit 1557a97

3 files changed

Lines changed: 37 additions & 12 deletions

File tree

‎CONTRIBUTORS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@
1616
| mo-alistairp | Alistair Pirrie | Met Office | 2026-01-19 |
1717
| jasonjunweilyu | Junwei (Jason) Lyu | Bureau of Meteorology, Australia | 2025-12-17 |
1818
| EdHone | Ed Hone | Met Office | 2026-01-26 |
19+
| alanjhewitt | Alan J Hewitt | Met Office | 2026-01-28 |

‎interfaces/physics_schemes_interface/source/kernel/radaer_kernel_mod.F90‎

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1139,15 +1139,17 @@ subroutine radaer_code( nlayers, &
11391139
if ( .not. associated( aod_ukca_ait_sol, empty_real_data ) ) then
11401140
do k = 1, npd_ukca_aod_wavel
11411141
do i = 1, row_length
1142-
aod_ukca_ait_sol( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
1142+
aod_ukca_ait_sol( map_aod_wavel(i) + k - 1 ) = &
1143+
aod_ukca_this_mode_um(i,k)
11431144
end do
11441145
end do
11451146
end if
11461147

11471148
if ( .not. associated( aaod_ukca_ait_sol, empty_real_data ) ) then
11481149
do k = 1, npd_ukca_aod_wavel
11491150
do i = 1, row_length
1150-
aaod_ukca_ait_sol( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
1151+
aaod_ukca_ait_sol( map_aod_wavel(i) + k - 1 ) = &
1152+
aaod_ukca_this_mode_um(i,k)
11511153
end do
11521154
end do
11531155
end if
@@ -1224,15 +1226,17 @@ subroutine radaer_code( nlayers, &
12241226
if ( .not. associated( aod_ukca_acc_sol, empty_real_data ) ) then
12251227
do k = 1, npd_ukca_aod_wavel
12261228
do i = 1, row_length
1227-
aod_ukca_acc_sol( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
1229+
aod_ukca_acc_sol( map_aod_wavel(i) + k - 1 ) = &
1230+
aod_ukca_this_mode_um(i,k)
12281231
end do
12291232
end do
12301233
end if
12311234

12321235
if ( .not. associated( aaod_ukca_acc_sol, empty_real_data ) ) then
12331236
do k = 1, npd_ukca_aod_wavel
12341237
do i = 1, row_length
1235-
aaod_ukca_acc_sol( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
1238+
aaod_ukca_acc_sol( map_aod_wavel(i) + k - 1 ) = &
1239+
aaod_ukca_this_mode_um(i,k)
12361240
end do
12371241
end do
12381242
end if
@@ -1309,15 +1313,17 @@ subroutine radaer_code( nlayers, &
13091313
if ( .not. associated( aod_ukca_cor_sol, empty_real_data ) ) then
13101314
do k = 1, npd_ukca_aod_wavel
13111315
do i = 1, row_length
1312-
aod_ukca_cor_sol( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
1316+
aod_ukca_cor_sol( map_aod_wavel(i) + k - 1 ) = &
1317+
aod_ukca_this_mode_um(i,k)
13131318
end do
13141319
end do
13151320
end if
13161321

13171322
if ( .not. associated( aaod_ukca_cor_sol, empty_real_data ) ) then
13181323
do k = 1, npd_ukca_aod_wavel
13191324
do i = 1, row_length
1320-
aaod_ukca_cor_sol( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
1325+
aaod_ukca_cor_sol( map_aod_wavel(i) + k - 1 ) = &
1326+
aaod_ukca_this_mode_um(i,k)
13211327
end do
13221328
end do
13231329
end if
@@ -1394,15 +1400,17 @@ subroutine radaer_code( nlayers, &
13941400
if ( .not. associated( aod_ukca_ait_ins, empty_real_data ) ) then
13951401
do k = 1, npd_ukca_aod_wavel
13961402
do i = 1, row_length
1397-
aod_ukca_ait_ins( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
1403+
aod_ukca_ait_ins( map_aod_wavel(i) + k - 1 ) = &
1404+
aod_ukca_this_mode_um(i,k)
13981405
end do
13991406
end do
14001407
end if
14011408

14021409
if ( .not. associated( aaod_ukca_ait_ins, empty_real_data ) ) then
14031410
do k = 1, npd_ukca_aod_wavel
14041411
do i = 1, row_length
1405-
aaod_ukca_ait_ins( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
1412+
aaod_ukca_ait_ins( map_aod_wavel(i) + k - 1 ) = &
1413+
aaod_ukca_this_mode_um(i,k)
14061414
end do
14071415
end do
14081416
end if
@@ -1479,15 +1487,17 @@ subroutine radaer_code( nlayers, &
14791487
if ( .not. associated( aod_ukca_acc_ins, empty_real_data ) ) then
14801488
do k = 1, npd_ukca_aod_wavel
14811489
do i = 1, row_length
1482-
aod_ukca_acc_ins( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
1490+
aod_ukca_acc_ins( map_aod_wavel(i) + k - 1 ) = &
1491+
aod_ukca_this_mode_um(i,k)
14831492
end do
14841493
end do
14851494
end if
14861495

14871496
if ( .not. associated( aaod_ukca_acc_ins, empty_real_data ) ) then
14881497
do k = 1, npd_ukca_aod_wavel
14891498
do i = 1, row_length
1490-
aaod_ukca_acc_ins( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
1499+
aaod_ukca_acc_ins( map_aod_wavel(i) + k - 1 ) = &
1500+
aaod_ukca_this_mode_um(i,k)
14911501
end do
14921502
end do
14931503
end if
@@ -1564,15 +1574,17 @@ subroutine radaer_code( nlayers, &
15641574
if ( .not. associated( aod_ukca_cor_ins, empty_real_data ) ) then
15651575
do k = 1, npd_ukca_aod_wavel
15661576
do i = 1, row_length
1567-
aod_ukca_cor_ins( map_aod_wavel(i) + k ) = aod_ukca_this_mode_um(i,k)
1577+
aod_ukca_cor_ins( map_aod_wavel(i) + k - 1 ) = &
1578+
aod_ukca_this_mode_um(i,k)
15681579
end do
15691580
end do
15701581
end if
15711582

15721583
if ( .not. associated( aaod_ukca_cor_ins, empty_real_data ) ) then
15731584
do k = 1, npd_ukca_aod_wavel
15741585
do i = 1, row_length
1575-
aaod_ukca_cor_ins( map_aod_wavel(i)+k ) = aaod_ukca_this_mode_um(i,k)
1586+
aaod_ukca_cor_ins( map_aod_wavel(i) + k - 1 ) = &
1587+
aaod_ukca_this_mode_um(i,k)
15761588
end do
15771589
end do
15781590
end if

‎rose-stem/app/lfric_coupled/file/mydef.xml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,18 @@
140140
<field field_ref="chemistry__dmso" />
141141
<field field_ref="chemistry__monoterpene" />
142142
<field field_ref="chemistry__secondary_organic" />
143+
<field field_ref="aerosol__aod_ukca_ait_sol" />
144+
<field field_ref="aerosol__aaod_ukca_ait_sol" />
145+
<field field_ref="aerosol__aod_ukca_acc_sol" />
146+
<field field_ref="aerosol__aaod_ukca_acc_sol" />
147+
<field field_ref="aerosol__aod_ukca_cor_sol" />
148+
<field field_ref="aerosol__aaod_ukca_cor_sol" />
149+
<field field_ref="aerosol__aod_ukca_ait_ins" />
150+
<field field_ref="aerosol__aaod_ukca_ait_ins" />
151+
<field field_ref="aerosol__aod_ukca_acc_ins" />
152+
<field field_ref="aerosol__aaod_ukca_acc_ins" />
153+
<field field_ref="aerosol__aod_ukca_cor_ins" />
154+
<field field_ref="aerosol__aaod_ukca_cor_ins" />
143155
<field field_ref="aerosol__n_nuc_sol" />
144156
<field field_ref="aerosol__n_ait_sol" />
145157
<field field_ref="aerosol__n_acc_sol" />

0 commit comments

Comments
 (0)