fix(extension-redis): unsubscribe from pubsub#945
Merged
janthurau merged 1 commit intoueberdosis:mainfrom Jul 19, 2025
Merged
Conversation
Contributor
|
Thank you! |
|
Shouldn't redis unsubscribe on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Redis PubSub is not unsubscribed due to delayed disconnect logic.
The Redis subscription unsubscribe code is behind a
setTimeoutwhich checks if thedocumentinstance is still available on the parentinstance, which for us is never since the document is disposed by the time thesetTimeoutcode is called.Additionally, the existing
unloadDocumentcall is suspect, but I left it in with a check for a validdocumentinstance.