fix: remove awareness stats on page unload instead of beforeunload#658
Merged
janthurau merged 1 commit intoueberdosis:mainfrom Jul 29, 2023
iowxy:main
Merged
fix: remove awareness stats on page unload instead of beforeunload#658janthurau merged 1 commit intoueberdosis:mainfrom iowxy:main
janthurau merged 1 commit intoueberdosis:mainfrom
iowxy:main
Conversation
janthurau
approved these changes
Jul 29, 2023
Contributor
janthurau
left a comment
There was a problem hiding this comment.
Totally makes sense. Thanks for this!
I guess we added beforeUnload to make sure the awareness message can actually arrive at the server, but seems this works fine (yjs/y-websocket#119).
janthurau
pushed a commit
to YousefED/hocuspocus
that referenced
this pull request
Aug 12, 2023
…eberdosis#658) Co-authored-by: 范文华 <fanwh@yealink.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I notice the code in file
packages/provider/src/HocuspocusProvider.tsI must say that what if I prevent the page to be close? consider this logic below
Develop can write intercept logic and users may cancel to close this page.