Conversation
tommoor
commented
Aug 18, 2021
37 tasks
hanspagel
reviewed
Aug 19, 2021
hanspagel
reviewed
Aug 19, 2021
hanspagel
approved these changes
Aug 19, 2021
…nAuthenticationFailed callbacks
Contributor
|
Amazing PR! I’ve added some happy path tests, and left some comments. ✌️ Oh, and I had to research it, but Drafts are a premium feature for private repositories. |
hanspagel
approved these changes
Aug 19, 2021
Contributor
hanspagel
left a comment
There was a problem hiding this comment.
Thanks for the update!
Contributor
|
Released as @hocuspocus/[email protected] 🎉 Thanks for your work on this, this was really a superb contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds token based authentication over the websocket, this replaces the current solution of using query parameters which can easily end up in logs and "bakes in" the concept of authentication and authorization more clearly.
Docs are updated, but the main interface differences are as so:
HocuspocusProvidergains atokenoption to pass an auth/access token to the server (or any other string-based authentication you might have).Servergains an optional "onAuthenticate" hook, this acts much likeonConnectbefore, but instead of accessing the query parameters object it is passed thetokenfrom the client. If the hook is not provided then no authentication is required.Of note:
closes #109
closes yjs/y-websocket#67