Skip to content

Conversation

@msridhar
Copy link
Collaborator

@msridhar msridhar commented Jun 17, 2025

Fixes #1219

Previously, we would only consider the isNotNull method of org.assertj.core.api.AbstractAssert to be valid. Now, we allow isNotNull of any class that implements the org.assertj.core.api.Assert interface, which handles the case from #1219 and more.

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (6cfccfd) to head (116f1a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1221   +/-   ##
=========================================
  Coverage     88.30%   88.31%           
- Complexity     2353     2356    +3     
=========================================
  Files            89       89           
  Lines          7662     7668    +6     
  Branches       1535     1536    +1     
=========================================
+ Hits           6766     6772    +6     
  Misses          450      450           
  Partials        446      446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msridhar msridhar marked this pull request as ready for review June 17, 2025 23:48
@msridhar msridhar requested review from akshayutture and yuxincs June 17, 2025 23:49
@msridhar msridhar merged commit 5209429 into master Jun 18, 2025
12 checks passed
@msridhar msridhar deleted the assertj-isnotnull-collections branch June 18, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assertThat(...).isNotNull() does not qualify null-check for collections

3 participants