Query Builder and RSpec matcher #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mknapik
force-pushed
the
feature/query_builder
branch
from
680ceb6 to
1bf72e4
Compare
examples/spec/query_spec.rb
Outdated
| result = connection.fetch(query) | ||
|
|
||
| aggregate_failures do | ||
| names = result.map { |row| row[:name] } |
Contributor
Author
There was a problem hiding this comment.
@jekuta Use out new awesome matcher.
Contributor
|
@mknapik @jekuta Looks really nice! |
|
|
||
| let(:schema) { subject.table_schema } | ||
|
|
||
| before { connection.execute(schema.create_table_statement) } |
Contributor
There was a problem hiding this comment.
the old way for this: before { connection.create_table(schema) }
lauratpa
force-pushed
the
feature/query_builder
branch
from
2286eda to
94c1eae
Compare
|
|
||
| def partition(hash) | ||
| partition_hash.merge!(hash) | ||
| self |
Contributor
There was a problem hiding this comment.
@mknapik Since we do work on an instance of the query, I changed the dup.tap { |builder| #do something with the copy } into making the change and returning self. This way we can still chain the methods as before, but we skip creating new objects every time a method is called.
lauratpa
force-pushed
the
feature/query_builder
branch
from
bdbf047 to
b4a17b0
Compare
|
|
||
| before { connection.execute(schema.create_table_statement) } | ||
|
|
||
| context 'if we have a partition' do |
Contributor
There was a problem hiding this comment.
@mknapik I add a fast example on partition, but this could probably be more clear.
lauratpa
force-pushed
the
feature/query_builder
branch
from
2a68e2c to
ebff089
Compare
* RuboCop fixes and .rubocop.yml adjustments * make query_spec example prettier * remove unused Rows * Allow to inject row hashes with symbol and string keys * immutable and mutable QueryBuilder
* test on multiple rubies
mknapik
force-pushed
the
feature/query_builder
branch
from
1768b89 to
470f69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match_result_setfor expectationsrbhivefork fixes types (namespace TYPE_NAMES and require the parent file forward3d/rbhive#22)