Javadoc fixes

Author: mernst

checker/bin-devel/build.sh

@@ -11,8 +11,8 @@ source "$SCRIPTDIR"/clone-related.sh
 # Download dependencies, trying a second time if there is a failure.
 # echo "NO_WRITE_VERIFICATION_METADATA=$NO_WRITE_VERIFICATION_METADATA"
 if [ -z "${NO_WRITE_VERIFICATION_METADATA+x}" ]; then
-  (TERM=dumb timeout 300 ./gradlew --write-verification-metadata sha256 help --dry-run \
-    || (sleep 1m && TERM=dumb timeout 300 ./gradlew --write-verification-metadata sha256 help --dry-run))
+  (date && TERM=dumb timeout 300 ./gradlew --write-verification-metadata sha256 help --dry-run) \
+    || (sleep 1m && date && TERM=dumb timeout 300 ./gradlew --write-verification-metadata sha256 help --dry-run)
 fi
 echo "running \"./gradlew assemble\" for checker-framework"
 ./gradlew assemble --console=plain -Dorg.gradle.internal.http.socketTimeout=60000 -Dorg.gradle.internal.http.connectionTimeout=60000

checker/bin-devel/git.pre-commit

@@ -19,10 +19,10 @@ if [ -n "$CHANGED_JAVA_FILES" ]; then
   if [ "$BRANCH" = "master" ]; then
     git diff --staged > /tmp/diff.txt
     ./gradlew --stacktrace getPlumeScripts
-    (./gradlew requireJavadoc > /tmp/warnings-rjp.txt 2>&1) || true
-    checker/bin-devel/.plume-scripts/lint-diff.py --guess-strip /tmp/diff.txt /tmp/warnings-rjp.txt
-    (./gradlew javadocDoclintAll > /tmp/warnings-jda.txt 2>&1) || true
-    checker/bin-devel/.plume-scripts/lint-diff.py --guess-strip /tmp/diff.txt /tmp/warnings-jda.txt
+    (./gradlew requireJavadoc > /tmp/warnings-requireJavadoc.txt 2>&1) || true
+    checker/bin-devel/.plume-scripts/lint-diff.py --guess-strip /tmp/diff.txt /tmp/warnings-requireJavadoc.txt
+    (./gradlew javadocDoclintAll > /tmp/warnings-javadocDoclintAll.txt 2>&1) || true
+    checker/bin-devel/.plume-scripts/lint-diff.py --guess-strip /tmp/diff.txt /tmp/warnings-javadocDoclintAll.txt
   fi
 fi
 

checker/bin-devel/test-misc.sh

@@ -37,10 +37,10 @@ make style-check --jobs="$(getconf _NPROCESSORS_ONLN)"
 if [ -f SKIP-REQUIRE-JAVADOC ]; then
   echo "Skipping requireJavadoc because file SKIP-REQUIRE-JAVADOC exists."
 else
-  (./gradlew requireJavadoc --console=plain --warning-mode=all > /tmp/warnings-rjp.txt 2>&1) || true
-  "$PLUME_SCRIPTS"/ci-lint-diff /tmp/warnings-rjp.txt || status=1
-  (./gradlew javadocDoclintAll --console=plain --warning-mode=all > /tmp/warnings-jda.txt 2>&1) || true
-  "$PLUME_SCRIPTS"/ci-lint-diff /tmp/warnings-jda.txt || status=1
+  (./gradlew requireJavadoc --console=plain --warning-mode=all > /tmp/warnings-requireJavadoc.txt 2>&1) || true
+  "$PLUME_SCRIPTS"/ci-lint-diff /tmp/warnings-requireJavadoc.txt || status=1
+  (./gradlew javadocDoclintAll --console=plain --warning-mode=all > /tmp/warnings-javadocDoclintAll.txt 2>&1) || true
+  "$PLUME_SCRIPTS"/ci-lint-diff /tmp/warnings-javadocDoclintAll.txt || status=1
 fi
 if [ $status -ne 0 ]; then exit $status; fi
 

checker/src/main/java/org/checkerframework/checker/index/substringindex/SubstringIndexAnnotatedTypeFactory.java

@@ -74,7 +74,7 @@ protected DependentTypesHelper createDependentTypesHelper() {
 
   /**
    * The Substring Index qualifier hierarchy. The hierarchy consists of a top element {@link
-   * UNKNOWN} of type {@link SubstringIndexUnknown}, bottom element {@link BOTTOM} of type {@link
+   * #UNKNOWN} of type {@link SubstringIndexUnknown}, bottom element {@link #BOTTOM} of type {@link
    * SubstringIndexBottom}, and elements of type {@link SubstringIndexFor} that follow the subtyping
    * relation of {@link UBQualifier}.
    */

checker/src/main/java/org/checkerframework/checker/rlccalledmethods/RLCCalledMethodsAnalysis.java

@@ -3,6 +3,7 @@
 import javax.lang.model.type.TypeMirror;
 import org.checkerframework.checker.calledmethods.CalledMethodsAnalysis;
 import org.checkerframework.checker.calledmethods.CalledMethodsAnnotatedTypeFactory;
+import org.checkerframework.checker.resourceleak.ResourceLeakChecker;
 import org.checkerframework.checker.resourceleak.SetOfTypes;
 
 /**