Skip to content

Commit 145ab4a

Browse files
felixbrjenkins
authored andcommitted
util|finagle|finatra|twitter-server|scrooge: Bump Scalacheck to 1.15.4 in sbt
Problem Scala 3 requires Scalacheck 1.15.x but the sbt builds currently uses 1.14.x Solution Upgrade Scalacheck in build.sbt to 1.15.4 to simplify Scala 3 cross-building. Result The tests use Scalacheck 1.15.4. We still use `scalatestplus scalacheck-1-14` because there is no `1-15` version available for Scalatest 3.1.x. Closes twitter/util#291 Signed-off-by: Lily He <[email protected]> JIRA Issues: CSL-11064 Differential Revision: https://phabricator.twitter.biz/D691691
1 parent 5e9998f commit 145ab4a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ Runtime Behavior Changes
1212

1313
* finagle: Update Caffeine cache library to version 2.9.1 ``PHAB_ID=D660908``
1414

15+
* finagle: Update Scalatest to version 1.15.4 ``PHAB_ID=D691691``
16+
1517
* finagle-http: remove the `com.twitter.finagle.http.UseH2`,
1618
`com.twitter.finagle.http.UseH2CClients2`, `com.twitter.finagle.http.UseH2CServers` and
1719
`com.twitter.finagle.http.UseHttp2MultiplexCodecClient` toggles. The configuration for

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ val sharedSettings = Seq(
147147
libraryDependencies ++= Seq(
148148
// See https://www.scala-sbt.org/0.13/docs/Testing.html#JUnit
149149
"com.novocode" % "junit-interface" % "0.11" % "test",
150-
"org.scalacheck" %% "scalacheck" % "1.14.3" % "test",
150+
"org.scalacheck" %% "scalacheck" % "1.15.4" % "test",
151151
"org.scalatest" %% "scalatest" % "3.1.1" % "test",
152152
"org.scalatestplus" %% "junit-4-12" % "3.1.2.0" % "test",
153153
"org.scalatestplus" %% "mockito-1-10" % "3.1.0.0" % "test",

0 commit comments

Comments
 (0)