Merged
Conversation
pep517 has been deprecated for a long time and we don't need it anymore, courtesy of importlib.metadata.
The default pip versions are good enought, nowadays.
Member
Author
|
I tried a fake version and looks good! cf https://github.com/twisted/towncrier/actions/runs/10175573095/job/28143297512 |
This reverts commit 3aadb6a.
adiroiban
approved these changes
Jul 31, 2024
Member
adiroiban
left a comment
adiroiban
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pep517 has been deprecated for a long time and we don't need it anymore, courtesy of
importlib.metadata.I appreciate that it's a bit icky since we cannot test it before actually releasing, and I really don't want to slow down a future release.