Remove github edit link in non-trunk versions of docs#596
Remove github edit link in non-trunk versions of docs#596adiroiban merged 2 commits intotwisted:trunkfrom
Conversation
adiroiban
left a comment
There was a problem hiding this comment.
Looks good. Thanks.
I can see that edit link is not enabled for the build on this PR https://towncrier--596.org.readthedocs.build/en/596/tutorial.html
Let's merge and see that the edit page is still enabled on https://towncrier.readthedocs.io/en/latest/tutorial.html
|
Hi Chris. It looks like this does not work as expected. We don't have the edit links for the "latest" version - https://towncrier.readthedocs.io/en/latest/tutorial.html The edit link is present on "trunk" https://towncrier.readthedocs.io/en/trunk/tutorial.html but I don't think that people are using the "trunk" url. The defaul version is "stable" ...aka latest tag - https://towncrier.readthedocs.io/en/stable/ Note that on Read The Docs, we have 2 builds for each merge in trunk https://readthedocs.org/projects/towncrier/builds/ The "trunk" build and the "latest" build. @SmileyChris can you please send another PR that will also include "latest" in the list version with edit enabled ? Thanks! |
Description
In the sphinx configuration, remove github edit link in non-trunk versions of docs.
This only triggers specifically for read the docs, since it's based one of their custom environment variables.
Fixes #505