fix: Also render title in markdown template without name#587
Merged
adiroiban merged 1 commit intotwisted:trunkfrom Apr 19, 2024
Merged
fix: Also render title in markdown template without name#587adiroiban merged 1 commit intotwisted:trunkfrom
adiroiban merged 1 commit intotwisted:trunkfrom
Conversation
adiroiban
approved these changes
Apr 16, 2024
Member
adiroiban
left a comment
There was a problem hiding this comment.
Many thanks for the changes.
They look good.
I left a few minor comments.
I hope we can have those improvemnets before the merge.
Thanks again!
0e48c1d to
be83bf2
Compare
Contributor
Author
|
Great suggestions, thanks! Applied them :D |
1294080 to
d34caa9
Compare
Member
|
Thanks for your help. I have enabled auto-merge. I hope this will land soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, if there was no project name defined, the default markdown template wouldn't render the title properly due to a missing
#.Checklist
src/towncrier/newsfragments/. Describe yourchange and include important information. Your change will be included in the public release notes.