Clean tooltip component unneeded functionality

[GeoSot]

Preview: https://deploy-preview-32692--twbs-bootstrap.netlify.app/docs/5.1/components/tooltips/

[XhmikosR]

So, basically this removes the ability to use the CSS classes for positioning the tooltips? Not sure I follow all the changes.

@MartijnCuppens you recently had a look at popper too.

[GeoSot]

So, basically this removes the ability to use the CSS classes for positioning the tooltips?

This is the half truth ;)

it still uses this:

.bs-tooltip-auto {
  &[data-popper-placement^="top"] {
    @extend .bs-tooltip-top;
  }
  &[data-popper-placement^="right"] {
    @extend .bs-tooltip-end;
  }
  &[data-popper-placement^="bottom"] {
    @extend .bs-tooltip-bottom;
  }
  &[data-popper-placement^="left"] {
    @extend .bs-tooltip-start;
  }
}

and as important on my opinion, it removes many of js, to be easier for future maintenance.

This can do the difference too

I only chose this solution as it pulls out some extra stuff

[XhmikosR]

So, this patch still has the issue with tooltip randomly showing up in the wrong position when hovering fast, multiple times. But at least, it does show.

[GeoSot]

So, this patch still has the issue with tooltip randomly showing up in the wrong position when hovering fast, multiple times. But at least, it does show.

If we remove the fallbackPlacements: this.config.fallbackPlacements (and probably disable the possibility to be overridden by config, as Rohit correctly pointed out), it fixes this issue

Also popper overrides the css properties position and margin so I omitted them

[mdo]

@GeoSot @rohit2sharma95 What work remains here? I see tests are failing and we might still have the same issue with the fast hovering bug. Do we need to do something similar as #32843? Something else?

[GeoSot]

@mdo

Only the coverage is failing and I am not sure why, as I removed many lines.

If you see my previous messages, at least till now, I am on the proposal to remove fallbackPlacements as #32843 and I think we will be much better, than now

[mdo]

If you see my previous messages, at least till now, I am on the proposal to remove fallbackPlacements as #32843 and I think we will be much better, than now

I'm down to try anything at this point :). @rohit2sharma95 and @XhmikosR would know better what the implications of that might be though.

[XhmikosR]

I'm still seeing the issue with tooltip showing to the wrong position when hovering too fast. :/

[GeoSot]

@XhmikosR
You see the glitch because we decided to revert the fallbackPlacements
I deleted again, so give it one more try

[XhmikosR]

Confirmed, now it works! @rohit2sharma95 please review this, I added it in beta2 :)

[XhmikosR]

@GeoSot do the current tests in this branch catch this issue? We should make sure this doesn't happen again :)

[GeoSot]

if you have any idea, how to do these tests, I would appreciate, any help or opinion

[XhmikosR]

Unfortunately, I don't know how either. Maybe @rohit2sharma95 can help us here?

[rohit2sharma95]

Removing the default value for fallbackPlacements can be considered as the stable solution? 🤔
The value for this option can be overridden by the user (Via popperConfig or fallbackPlacements option). This way, the user can not be prevented by doing so 🙂

[XhmikosR]

We definitely need tests for this...

Tomorrow we'll release beta2, so if this isn't ready we'll move it beta3 to that there's no time pressure.