Skip to content

transition() mixin prevent redundant 'transition: none' and pass null #30391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2020
Merged

transition() mixin prevent redundant 'transition: none' and pass null #30391

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6e2ac0
Prevent redundant 'none' for prefers-reduced-motion
ysds Mar 14, 2020
a3130a0
Output warning when use 'none' or 'null' with multiple arguments
ysds Mar 14, 2020
2c5e039
Fix for libsass(node-sass)
ysds Mar 14, 2020
b3a4c17
Merge branch 'master' into master-ysds-transition-mixin
MartijnCuppens Mar 15, 2020
6ef705b
Merge branch 'master' into master-ysds-transition-mixin
MartijnCuppens Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions scss/mixins/_transition.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
// stylelint-disable property-blacklist
@mixin transition($transition...) {
@if length($transition) == 0 {
$transition: $transition-base;
}

@if length($transition) > 1 {
@each $value in $transition {
@if $value == null or $value == none {
@warn "The keyword 'none' or 'null' must be used as a single argument.";
}
}
}

@if $enable-transitions {
@if length($transition) == 0 {
transition: $transition-base;
} @else {
@if nth($transition, 1) != null {
transition: $transition;
}

@if $enable-prefers-reduced-motion-media-query {
@if $enable-prefers-reduced-motion-media-query and nth($transition, 1) != null and nth($transition, 1) != none {
@media (prefers-reduced-motion: reduce) {
transition: none;
}
Expand Down