-
-
Notifications
You must be signed in to change notification settings - Fork 79.2k
Set auto as default @page size #28753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MartijnCuppens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the value to null, since this won't generate any additional css. Need an additional approval from @twbs/css-review to be sure.
|
does this cause any additional issues a la #26598, or does it solve them? |
We'll need to investigate this more, this seems to break the Bootstrap site for example (macOS, Chrome)
|
I did some research about this and it seems browsers behave pretty inconsistent and there are a lot of factors we can not control:
I think we should just ditch the page size and Maybe we should also mention the problems with print layouts in our docs. |
|
Just a reminder, we need to be extra careful with this since it's for v4. If we can't be 100% sure about any side effects, I say we leave it as is... |
|
historically the print styles have been broken/problematic in many tiny aspects, so if this fixes at least some of the common situations even though it may not get to 100% perfection every time, it's probably an improvement though |
|
I agree with Patrick. #25164 broke more than it fixed I'm afraid. But this PR shouldn't be merged without removing (or |
|
@mdo, what do you think, should we remove the size and min-width or leave it as is? |
|
Ping @mdo |
|
Ping @mdo for a decision. |
|
I'm still not sure about this change @mdo. It can and will introduce change in behavior. See the above comments #28753 (comment) |
|
Hmm, re-reading again, I could be convinced to not do this and just drop it entirely like we have in v5. The change could be seen as a breaking one for others. |
|
Fine by me, close it than? |
See:
I think any option would be better than "a3"