From 605f57687a94491d646aedd13adac3c8707de504 Mon Sep 17 00:00:00 2001 From: Arvind S Date: Tue, 9 Oct 2018 10:37:29 +0530 Subject: [PATCH 1/5] Made the disabled state for nav more obvious. Disabled pointer events and changed cursor to default as per #27380 --- scss/_nav.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scss/_nav.scss b/scss/_nav.scss index fc82161e3413..f1a807160419 100644 --- a/scss/_nav.scss +++ b/scss/_nav.scss @@ -22,6 +22,8 @@ // Disabled state lightens text &.disabled { color: $nav-link-disabled-color; + pointer-events: none; + cursor: default; } } @@ -48,6 +50,8 @@ color: $nav-link-disabled-color; background-color: transparent; border-color: transparent; + pointer-events: none; + cursor: default; } } From 1cefa36d35fda5aeeadb30e92b2eb899e04a966a Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 13 Oct 2018 14:44:03 +0300 Subject: [PATCH 2/5] Update _nav.scss --- scss/_nav.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/_nav.scss b/scss/_nav.scss index f1a807160419..ac141d9ec981 100644 --- a/scss/_nav.scss +++ b/scss/_nav.scss @@ -49,8 +49,8 @@ &.disabled { color: $nav-link-disabled-color; background-color: transparent; - border-color: transparent; pointer-events: none; + border-color: transparent; cursor: default; } } From d4bc716522b833ed9a8ffe338ceaae624d58a4e2 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 13 Oct 2018 14:48:16 +0300 Subject: [PATCH 3/5] Update _nav.scss --- scss/_nav.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scss/_nav.scss b/scss/_nav.scss index ac141d9ec981..851e45e1343b 100644 --- a/scss/_nav.scss +++ b/scss/_nav.scss @@ -48,10 +48,10 @@ &.disabled { color: $nav-link-disabled-color; - background-color: transparent; pointer-events: none; - border-color: transparent; + background-color: transparent; cursor: default; + border-color: transparent; } } From 82aeb9f17bf97de404b084ef87b57729433789ef Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Sat, 13 Oct 2018 14:49:12 +0300 Subject: [PATCH 4/5] Update _nav.scss --- scss/_nav.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/_nav.scss b/scss/_nav.scss index 851e45e1343b..7c58832b163f 100644 --- a/scss/_nav.scss +++ b/scss/_nav.scss @@ -49,8 +49,8 @@ &.disabled { color: $nav-link-disabled-color; pointer-events: none; - background-color: transparent; cursor: default; + background-color: transparent; border-color: transparent; } } From 95884b6ead29dab1482c0e2cee000b5894f4f534 Mon Sep 17 00:00:00 2001 From: Arvind S Date: Sat, 27 Oct 2018 02:22:25 +0530 Subject: [PATCH 5/5] Removed redundant code Done as per code review on issue #27382. --- scss/_nav.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/scss/_nav.scss b/scss/_nav.scss index 7c58832b163f..e5519b3a4d2d 100644 --- a/scss/_nav.scss +++ b/scss/_nav.scss @@ -48,8 +48,6 @@ &.disabled { color: $nav-link-disabled-color; - pointer-events: none; - cursor: default; background-color: transparent; border-color: transparent; }