From ee9bc2851baf79a6dcce54d22e94c8c6499770a7 Mon Sep 17 00:00:00 2001 From: Helmut Granda Date: Wed, 26 Sep 2018 15:59:19 -0500 Subject: [PATCH 1/3] Adds a note about the limitations on content being larger than the image. In the event that the content is larger than the image, the content will continue to be displayed outside the image itself. There are some workarounds but they apply only to browsers that support this option and IE11 is not one of them. --- site/_includes/callout-info-content-iamge-overlay-overflow.md | 4 ++++ site/docs/4.1/components/card.md | 1 + 2 files changed, 5 insertions(+) create mode 100644 site/_includes/callout-info-content-iamge-overlay-overflow.md diff --git a/site/_includes/callout-info-content-iamge-overlay-overflow.md b/site/_includes/callout-info-content-iamge-overlay-overflow.md new file mode 100644 index 000000000000..64112ac0bb7a --- /dev/null +++ b/site/_includes/callout-info-content-iamge-overlay-overflow.md @@ -0,0 +1,4 @@ +{% capture callout %} +Note that content should not be larger than the height of the image. If content is larger than the image the content will be displayed outside the image. +{% endcapture %} +{% include callout.html content=callout type="info" %} \ No newline at end of file diff --git a/site/docs/4.1/components/card.md b/site/docs/4.1/components/card.md index 25e9ec2d0ef6..bd0140f1483c 100644 --- a/site/docs/4.1/components/card.md +++ b/site/docs/4.1/components/card.md @@ -391,6 +391,7 @@ Turn an image into a card background and overlay your card's text. Depending on {% endcapture %} {% include example.html content=example %} +{% include callout-info-content-iamge-overlay-overflow.md %} ## Card styles From dbee61eb1c7536aeffe2178256bb8279420eba2c Mon Sep 17 00:00:00 2001 From: Helmut Granda Date: Wed, 26 Sep 2018 21:27:09 -0500 Subject: [PATCH 2/3] Adding call out note directly to the page. Instead of using an external source since this is only a one time note it is safe to be placed within the document itself. --- site/docs/4.1/components/card.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/site/docs/4.1/components/card.md b/site/docs/4.1/components/card.md index bd0140f1483c..305a1c50aa34 100644 --- a/site/docs/4.1/components/card.md +++ b/site/docs/4.1/components/card.md @@ -391,7 +391,11 @@ Turn an image into a card background and overlay your card's text. Depending on {% endcapture %} {% include example.html content=example %} -{% include callout-info-content-iamge-overlay-overflow.md %} + +{% capture callout %} +Note that content should not be larger than the height of the image. If content is larger than the image the content will be displayed outside the image. +{% endcapture %} +{% include callout.html content=callout type="info" %} ## Card styles From 88f8988f645108e5da38a403f75276509fb4eb61 Mon Sep 17 00:00:00 2001 From: Helmut Granda Date: Wed, 26 Sep 2018 21:27:46 -0500 Subject: [PATCH 3/3] Delete callout-info-content-iamge-overlay-overflow.md Deleting external file since it is not needed, the copy of this file will be added directly to card.md. --- site/_includes/callout-info-content-iamge-overlay-overflow.md | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 site/_includes/callout-info-content-iamge-overlay-overflow.md diff --git a/site/_includes/callout-info-content-iamge-overlay-overflow.md b/site/_includes/callout-info-content-iamge-overlay-overflow.md deleted file mode 100644 index 64112ac0bb7a..000000000000 --- a/site/_includes/callout-info-content-iamge-overlay-overflow.md +++ /dev/null @@ -1,4 +0,0 @@ -{% capture callout %} -Note that content should not be larger than the height of the image. If content is larger than the image the content will be displayed outside the image. -{% endcapture %} -{% include callout.html content=callout type="info" %} \ No newline at end of file