Skip to content

Cleanup .btn-link hover/focus properties #27250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andresgalante merged 2 commits into from
Sep 17, 2018
Merged

Cleanup .btn-link hover/focus properties #27250

andresgalante merged 2 commits into from
Sep 17, 2018

Conversation

@MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Sep 17, 2018

The background-color and border-color properties of .btn-link are redundant. This PR removes them.

Closes #27220

andresgalante
andresgalante approved these changes Sep 17, 2018
View reviewed changes
Copy link
Collaborator

@andresgalante andresgalante left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@andresgalante andresgalante merged commit bf4dab7 into twbs:v4-dev Sep 17, 2018
@mdo mdo mentioned this pull request Sep 17, 2018
Closed
@MartijnCuppens MartijnCuppens deleted the remove-properties-from-btn-link branch September 17, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo Awaiting requested review from mdo

1 more reviewer

@andresgalante andresgalante andresgalante approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

css v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MartijnCuppens @andresgalante @Johann-S @XhmikosR