Bump version to 4.1.0 for remaining files. #26259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
approved these changes
Apr 11, 2018
XhmikosR
force-pushed
the
v4-dev-xmr-bump-version
branch
from
fb3ca8d to
814bf71
Compare
mdo
approved these changes
Apr 15, 2018
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
What's the best way to account for this in v4.1.1? Curious why these files were missed—did our scripts fail, or did I screw it up? I can revisit the ship PR later.
Member
Author
|
You reverted those I guess. For index I'm 100% sure you reverted :)
…On Sun, Apr 15, 2018, 22:48 Mark Otto ***@***.***> wrote:
***@***.**** approved this pull request.
What's the best way to account for this in v4.1.1? Curious why these files
were missed—did our scripts fail, or did I screw it up? I can revisit the
ship PR later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26259 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtRc8varavss3fXw_eaLsKtEiv0jGks5to6QCgaJpZM4TPvAG>
.
|
XhmikosR
force-pushed
the
v4-dev-xmr-bump-version
branch
from
814bf71 to
1cc8d9a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26250.