Use .list-group-item-action for list group item variant #25338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Even without, it works as intended according to the CSS specificity.
mdo
reviewed
Jan 17, 2018
scss/mixins/_list-group.scss
Outdated
| button.list-group-item-#{$state} { | ||
| color: $color; | ||
|
|
||
| .list-group-item-action.list-group-item-#{$state} { |
Member
There was a problem hiding this comment.
Maybe nest this in the above selector?
.list-group-item-#{$state} {
// styles
&.list-group-item-action {
// styles
}
}
mdo
approved these changes
Jan 17, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a.list-group-itemhas been replaced to.list-group-item-actionin v4.Related:
This PR applies this approach to the mixin.