Add example of a Spanish translation for custom file input #25302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@mdo I've patched it because even though the spanish was correct, it wasn't what I'd expect from a file typed file. |
andresgalante
approved these changes
Jan 15, 2018
Closed
Member
Author
|
Thank you, @andresgalante! |
fitojb
reviewed
Mar 23, 2018
| $custom-file-text: ( | ||
| en: "Browse", | ||
| es: "Navegar" | ||
| es: "Elegir" |
There was a problem hiding this comment.
“Browse” is usually translated as Examinar (see, e.g., Microsoft Terminology)
fitojb
reviewed
Mar 23, 2018
| {% example html %} | ||
| <div class="custom-file"> | ||
| <input type="file" class="custom-file-input" id="customFileLang" lang="es"> | ||
| <label class="custom-file-label" for="customFileLang">Seleccionar Archivo</label> |
There was a problem hiding this comment.
This should be Seleccionar un archivo because: 1) some browsers use the tú treatment and others use usted; the infinitive is neutral in that sense; and 2) Title Case is not used in Spanish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a live docs example for a Spanish translation for the custom file input to test out #23612. The CSS for this isn't included in v4 by default—instead, it's in our docs CSS. In my testing, the translation works as intended. Similarly, setting a custom
langattribute on the<input>doesn't break the English default from our source Sass (meaning any additional languages from the$custom-file-textSass map will function correctly).This should close #23612 without any actual fix being implemented.