Skip to content

Update browser compatibility note for position: sticky (Edge supports it now) #25229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2018
Merged

Update browser compatibility note for position: sticky (Edge supports it now) #25229

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae3aa33
Update browser compatibility note for position: sticky
coliff Jan 8, 2018
f56a660
Update position.md
XhmikosR Jan 11, 2018
dc907fe
Merge branch 'v4-dev' into patch-2
XhmikosR Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/4.0/utilities/position.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Position an element at the bottom of the viewport, from edge to edge. Be sure yo

Position an element at the top of the viewport, from edge to edge, but only after you scroll past it. The `.sticky-top` utility uses CSS's `position: sticky`, which isn't fully supported in all browsers.

**Microsoft Edge and IE11 will render `position: sticky` as `position: relative`.** As such, we wrap the styles in a `@supports` query, limiting the stickiness to only browsers that properly can render it.
**IE11 and IE10 will render `position: sticky` as `position: relative`.** As such, we wrap the styles in a `@supports` query, limiting the stickiness to only browsers that properly can render it.
Copy link
Member

@patrickhlauke patrickhlauke Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that properly can render it" > "that can render it properly" ?

Copy link
Contributor Author

@coliff coliff Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that "that can render it properly" would read better.

Copy link
Member

@mdo mdo Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Feel free to (force) push a change for that and we can merge as soon as CI stuff gets sorted.


{% highlight html %}
<div class="sticky-top">...</div>
Expand Down