Skip to content

Conversation

@straube
Copy link
Contributor

@straube straube commented Jan 2, 2018

In the current v4-dev branch, the variable $custom-select-height is not being used in the _custom-forms.scss file. Instead, its default value is set there: $input-height. So, when one tries to change that variable's value it doesn't lead to the expected result. To fix that I'm simply using the variable from _variables.scss to set the .custom-select height.

@straube
Copy link
Contributor Author

straube commented Jan 10, 2018

After the last time I updated this pull request branch the build failed. The output shows an error that doesn't seem to be related to the code. I'm wondering if re-building it would make the checks to pass. Is that even possible?

@mdo
Copy link
Member

mdo commented Jan 16, 2018

@straube It was unrelated I imagine—Travis had some issues after patching those major vulnerabilities.

@mdo mdo merged commit a531b46 into twbs:v4-dev Jan 16, 2018
@mdo mdo mentioned this pull request Jan 16, 2018
@straube straube deleted the v4-dev-custom-select-height branch January 16, 2018 09:15
@unrevised6419
Copy link

unrevised6419 commented Jan 16, 2018

As $custom-select-height is $input-height int _variables.scss. This will fix height for sure.
#25331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants