Print tweaks #25164
Merged
Print tweaks #25164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address some inconsistencies between browsers when printing. It applies a min-width to the body so that the content better resembles what your might see on your screen. I've made it a variable for easy customizing, too.
…tent print experience across browsers
|
Hi, Great news! You mention that this should make Chrome and Safari look similar. The problem I had was with Chrome vs IE. Is it likely that this issue will be fixed too? Thank you! |
Member
Author
|
Just verified this improves things in IE11 and Edge. It's not 100%, but it's an improvement for sure. |
Closed
|
This broke my invoice page |
|
To clarify, it's supposed to be a smaller paper, so I had |
Contributor
|
I'll add here that this caused Chrome's print dialog to remove the "Orientation" option for me. |
Contributor
|
Chrome margins are wrong. why is this set to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new variables for printing—page
sizeandmin-widthfor the<body>and.container. Using the docs homepage as my example, this printed the most similar in macOS Chrome and Safari. I'll check in on Windows browsers before merging.While working on this, a few things came to light:
@page'ssize, hence themin-widths.@page. Addingmarginor!importantbroke thesizeproperty.I'm expecting even more issues across other browsers as I get into them.
Hopefully fixes #23864 and fixes #23992.
/cc @tigermarques @michaelkrieger