Skip to content

Conversation

@mdo
Copy link
Member

@mdo mdo commented Dec 30, 2017

Fixes #24811.

This adds .valid-feedback to our custom styles and server side examples; previously we ommitted this to suggest you don't always need valid feedback. In addition, this adds examples of the .{valid|invalid}-tooltip classes with a new subsection in the Validation docs.

This also update the validation tooltip styles to remove the fixed width; instead it should retain itself to the parent element.

/cc @ysds @tmorehouse

mdo added 2 commits December 30, 2017 13:02
Fixes #24811.

This adds .valid-feedback to our custom styles and server side examples; previously we ommitted this to suggest you don't always need valid feedback. In addition, this adds examples of the .{valid|invalid}-tooltip classes with a new subsection in the Validation docs.
@ysds
Copy link
Contributor

ysds commented Dec 31, 2017

Thanks. It is more helpful if documented that parent of .{valid|invalid}-tooltip needs to have position: relative like http://localhost:9001/docs/4.0/components/dropdowns/#examples

Wrap the dropdown’s toggle (your button or link) and the dropdown menu within .dropdown, or another element that declares position: relative;.

@mdo
Copy link
Member Author

mdo commented Dec 31, 2017

@ysds Added!

@mdo mdo merged commit 460849d into v4-dev Jan 3, 2018
@mdo mdo mentioned this pull request Jan 3, 2018
@mdo mdo deleted the validation-tooltip-example branch May 1, 2018 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants