Removes hardcoded value for .nav-link padding #25117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
force-pushed
the
v4-dev-andres-navbar-hardcoded-padding
branch
from
473ff15 to
d407160
Compare
mdo
approved these changes
Dec 29, 2017
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
No need for basing this on $nav-link-* variables.
This was referenced Dec 31, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nav-linkpadding within navbar is hardcoded to.5rem.@mdo I've created a new variable for this value, but I was unsure if we should use
$nav-link-padding-x / 2What do you think?