Skip to content

Commit e000933

Browse files
Remove dialog from the HTML5 shim style (#26269)
`<dialog>`, in browsers that support it, has user agent styles of `dialog { display:block; ...} dialog:not([open]) { display:none; }` by forcing it to `display:block` in the shim, the dialog is shown even when closed. There's no clean way to shim this for non-supporting browsers, but arguably these browsers would have further problems with pure `<dialog>` usage anyway, and it's up to authors to then use different elements/shims.
1 parent 871e083 commit e000933

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scss/_reboot.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ html {
4242

4343
// stylelint-disable selector-list-comma-newline-after
4444
// Shim for "new" HTML5 structural elements to display correctly (IE10, older browsers)
45-
article, aside, dialog, figcaption, figure, footer, header, hgroup, main, nav, section {
45+
article, aside, figcaption, figure, footer, header, hgroup, main, nav, section {
4646
display: block;
4747
}
4848
// stylelint-enable selector-list-comma-newline-after

0 commit comments

Comments
 (0)