Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Conversation

@Herst
Copy link
Collaborator

@Herst Herst commented Oct 6, 2018

  • W004 (deprecated remote option') → removed, since now the option has been removed
  • E022 (not be placed within other components) → remains
  • E032 (modal-dialog) → remains
  • E040 → removed, since it's v2 stuff
  • E046 (tabindex) → remains
  • E048 (role="dialog") → remains
  • E049 (role="document") → remains

Status

  • Code: done
  • Tests: done
  • Wiki: done

/CC @XhmikosR @Johann-S

@Herst Herst self-assigned this Oct 20, 2018
@Herst Herst added this to the v1.0.0 milestone Oct 20, 2018
@Herst Herst force-pushed the next branch 2 times, most recently from 622ae8b to 65d8daf Compare November 10, 2018 17:34
@Herst Herst changed the title [v.net] Modals [v1] Modals Dec 26, 2018
@Herst Herst force-pushed the next branch 2 times, most recently from dd8c5f2 to 0258293 Compare July 26, 2019 12:04
@Herst Herst force-pushed the next-modals branch 4 times, most recently from fcea104 to a4f2307 Compare July 26, 2019 15:31
Removed W004, and E040.
Ported E022, E032, E046, E048, and E049
@Herst Herst merged commit f7d2f09 into next Jul 28, 2019
@XhmikosR XhmikosR deleted the next-modals branch July 28, 2019 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants