This repository was archived by the owner on May 23, 2025. It is now read-only.
replace kotlin-result-calladapter with networkresult-calladapter #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
approved these changes
May 29, 2022
Collaborator
charlag
left a comment
charlag
left a comment
There was a problem hiding this comment.
Seems straightforward enough!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference between the two is that
NetworkResultis no inline class. This has two advantagesClassCastExceptioncrashes all over the placesuspendSteps to reproduce one instance of the crash: https://chaos.social/@ConnyDuck/108353117857711488
Code of NetworkResult Calladapter: https://github.com/connyduck/networkresult-calladapter
Regarding the weird crash, maybe I will try to isolate it so I can report it to Kotlin and/or Retrofit